[vlc-commits] [Git][videolan/vlc][master] filter_chain: remove buffer_new assert

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
663d154b by Thomas Guillem at 2026-04-22T13:15:08+00:00
filter_chain: remove buffer_new assert

Not having a buffer_new callback is valid, cf. filter_NewPicture().

Fixes the following assert when taking a snapshot from a video with
subtitles:

```
vlc: ../../src/misc/filter_chain.c:236: filter_chain_NewVideo: Assertion `owner->video->buffer_new != NULL' failed.
```

Fixes #29775

- - - - -


1 changed file:

- src/misc/filter_chain.c


Changes:

=====================================
src/misc/filter_chain.c
=====================================
@@ -233,7 +233,6 @@ filter_chain_t *filter_chain_NewVideo( vlc_object_t *obj, bool allow_change,
     if( owner != NULL && owner->video != NULL )
     {
         // keep this to get pictures for the last filter in the chain
-        assert( owner->video->buffer_new != NULL );
         chain->parent_video_owner = *owner;
     }
     else



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/663d154b8cf76444ba516194a4a829d5e9f40396

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/663d154b8cf76444ba516194a4a829d5e9f40396
You're receiving this email because of your account on code.videolan.org.