[vlc-commits] [Git][videolan/vlc][master] macosx: Do not immediately dealloc subtree node

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
68bb4936 by Claudio Cambra at 2026-04-30T14:00:09+00:00
macosx: Do not immediately dealloc subtree node

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCInputItem.m


Changes:

=====================================
modules/gui/macosx/library/VLCInputItem.m
=====================================
@@ -63,7 +63,6 @@ static void cb_subtree_added(input_item_t *p_item, input_item_node_t *p_node, vo
         VLCInputItem *inputItem = (__bridge VLCInputItem *)p_data;
         [inputItem subTreeAdded:p_node];
     });
-    input_item_node_Delete(p_node);
 }
 
 static const struct input_item_parser_cbs_t parserCallbacks =
@@ -103,6 +102,8 @@ static const struct input_item_parser_cbs_t parserCallbacks =
         input_item_parser_id_Release(_p_parserID);
     if (_vlcInputItem)
         input_item_Release(_vlcInputItem);
+    if (_subTree)
+        input_item_node_Delete(_subTree);
 }
 
 - (NSString *)name
@@ -445,6 +446,9 @@ static const struct input_item_parser_cbs_t parserCallbacks =
 
 - (void)subTreeAdded:(input_item_node_t *)p_node
 {
+    if (_subTree) {
+        input_item_node_Delete(_subTree);
+    }
     _subTree = p_node;
     [NSNotificationCenter.defaultCenter postNotificationName:VLCInputItemSubtreeAdded object:self];
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/68bb4936aba0975ec076f4a49b2989b5177ea464

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/68bb4936aba0975ec076f4a49b2989b5177ea464
You're receiving this email because of your account on code.videolan.org.