[vlc-commits] [Git][videolan/vlc][master] 2 commits: demux: mpeg: do not set `sylt-data` metadata in USLT tag handler

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
ec62aaaf by Fatih Uzunoglu at 2026-08-01T13:45:39+00:00
demux: mpeg: do not set `sylt-data` metadata in USLT tag handler

Instead of using the same name, unsynchronized sylt can use a different
name. This is so that if synchronized lyrics are available, it would be
provided instead of unsynchronized lyrics.

- - - - -
8c2c70d7 by Fatih Uzunoglu at 2026-08-01T13:45:39+00:00
qt: fallback to `sylt-uslt-data` if `sylt-data` metadata is not available

- - - - -


2 changed files:

- modules/demux/mpeg/es.c
- modules/gui/qt/player/player_controller.cpp


Changes:

=====================================
modules/demux/mpeg/es.c
=====================================
@@ -1651,12 +1651,12 @@ static int ID3TAG_Parse_Handler( uint32_t i_tag, const uint8_t *p_payload, size_
                 snprintf( psz_key, sizeof(psz_key), "Lyrics:%s", psz_language );
                 vlc_meta_SetExtra( p_sys->p_meta, psz_key, psz_text );
 
-                /* Provide a synthetic sylt-data entry at t=0 so the Qt lyrics
+                /* Provide a synthetic uslt-data entry at t=0 so the Qt lyrics
                  * panel can display USLT text using the same timed-lyrics path. */
                 char *psz_sylt;
                 if( asprintf( &psz_sylt, "0\x1F%s\x1E", psz_text ) >= 0 )
                 {
-                    vlc_meta_SetExtra( p_sys->p_meta, "sylt-data", psz_sylt );
+                    vlc_meta_SetExtra( p_sys->p_meta, "uslt-data", psz_sylt );
                     free( psz_sylt );
                 }
             }


=====================================
modules/gui/qt/player/player_controller.cpp
=====================================
@@ -203,6 +203,9 @@ void PlayerControllerPrivate::UpdateMeta( input_item_t *p_item )
              * Later meta refreshes may not carry sylt-data again, so keep the
              * cached buffer until the current media changes. */
             const char *psz_sylt_data = vlc_meta_GetExtra( p_item->p_meta, "sylt-data" );
+            if (!psz_sylt_data)
+                psz_sylt_data = vlc_meta_GetExtra( p_item->p_meta, "uslt-data" );
+
             if (psz_sylt_data != NULL)
             {
                 QByteArray newRaw( psz_sylt_data );



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e6779c9a91861e73867cfb7bb920234e1157c0c6...8c2c70d7be059e1fe83544b3aea89510c0693c26

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e6779c9a91861e73867cfb7bb920234e1157c0c6...8c2c70d7be059e1fe83544b3aea89510c0693c26
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help