[vlc-commits] [Git][videolan/vlc][3.0.x] codec: cea708: check row boundaries before decrement

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
7966813e by Steve Lhomme at 2026-08-15T06:14:11+00:00
codec: cea708: check row boundaries before decrement

Otherwise the uint8_t values overflow.

Fixes #29750

(cherry picked from commit ca61f71a5edb1a78d5107341d4a447d22419943c)
Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -


1 changed file:

- modules/codec/cea708.c


Changes:

=====================================
modules/codec/cea708.c
=====================================
@@ -739,8 +739,10 @@ static void CEA708_Window_Scroll( cea708_window_t *p_w )
             for( int i=p_w->i_firstrow; i <= p_w->i_lastrow; i++ )
                 p_w->rows[i-1] = p_w->rows[i];
             p_w->rows[p_w->i_lastrow] = NULL;
-            p_w->i_firstrow--;
-            p_w->i_lastrow--;
+            if( p_w->i_firstrow != 0 )
+                p_w->i_firstrow--;
+            if( p_w->i_lastrow != 0 )
+                p_w->i_lastrow--;
             break;
     }
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7966813e94928098520f275c7993496181842f8d

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7966813e94928098520f275c7993496181842f8d
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help