[vlc-commits] [Git][videolan/vlc][3.0.x] demux: ogg: fix skeleton read

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
4e025de7 by François Cartegnie at 2026-08-27T11:36:04+02:00
demux: ogg: fix skeleton read

fix #29959
Reported-by: Tristan Madani <tristan at talencesecurity.com>

(cherry picked from commit a97709883484dae914d18ed952ee7fb5eae649ee)
Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -


1 changed file:

- modules/demux/ogg.c


Changes:

=====================================
modules/demux/ogg.c
=====================================
@@ -3341,6 +3341,7 @@ bool Ogg_GetBoundsUsingSkeletonIndex( logical_stream_t *p_stream, int64_t i_time
 
     /* Then Lookup its index */
     unsigned const char *p_fwdbyte = p_stream->p_skel->p_index;
+    unsigned const char *p_end = p_fwdbyte + p_stream->p_skel->i_index_size;
     struct
     {
         int64_t i_pos;
@@ -3349,15 +3350,13 @@ bool Ogg_GetBoundsUsingSkeletonIndex( logical_stream_t *p_stream, int64_t i_time
 
     uint64_t i_keypoints_found = 0;
 
-    while( p_fwdbyte < p_fwdbyte + p_stream->p_skel->i_index_size
+    while( p_fwdbyte < p_end
            && i_keypoints_found < p_stream->p_skel->i_index )
     {
         uint64_t i_val;
-        p_fwdbyte = Read7BitsVariableLE( p_fwdbyte,
-                        p_fwdbyte + p_stream->p_skel->i_index_size, &i_val );
+        p_fwdbyte = Read7BitsVariableLE( p_fwdbyte, p_end, &i_val );
         current.i_pos += i_val;
-        p_fwdbyte = Read7BitsVariableLE( p_fwdbyte,
-                        p_fwdbyte + p_stream->p_skel->i_index_size, &i_val );
+        p_fwdbyte = Read7BitsVariableLE( p_fwdbyte, p_end, &i_val );
         current.i_time += i_val * p_stream->p_skel->i_indexstampden;
         if ( current.i_pos < 0 || current.i_time < 0 ) break;
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/4e025de7529ca8b7068b3fe3a0f70ac77479f940

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/4e025de7529ca8b7068b3fe3a0f70ac77479f940
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help