[vlc-commits] [Git][videolan/vlc][master] demux: mp4: fix leak on failure path

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
75a00c37 by Alexandre Janniaux at 2026-08-28T10:10:50+00:00
demux: mp4: fix leak on failure path

When the es_out fails to add the new elementary stream, the demuxer was
reutrning VLC_DEMUXER_SUCCESS but the allocated p_block was then never
sent forward nor released, so it was effectively leaked away at this
location.

- - - - -


1 changed file:

- modules/demux/mp4/heif.c


Changes:

=====================================
modules/demux/mp4/heif.c
=====================================
@@ -815,6 +815,7 @@ static int DemuxHEIF( demux_t *p_demux )
 
     if( !p_sys->id )
     {
+        block_Release(p_block);
         p_sys->current.p_infe = NULL; /* Goto next picture */
         return VLC_DEMUXER_SUCCESS;
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/75a00c37c1939ce971767a59c300448fa78e95f1

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/75a00c37c1939ce971767a59c300448fa78e95f1
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help