[vlc-commits] [Git][videolan/vlc][master] demux: mkv: dereference optional before passing debug()

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
ee862057 by Alexandre Janniaux at 2026-02-12T18:39:25+00:00
demux: mkv: dereference optional before passing debug()

Variadics might not know about std::optional<> since it triggers C code
and it might be undefined depending on the representation of optional<>.

Since we set the std::optional<> right before, ensure it returns the
wrapped value.

- - - - -


1 changed file:

- modules/demux/mkv/matroska_segment_parse.cpp


Changes:

=====================================
modules/demux/mkv/matroska_segment_parse.cpp
=====================================
@@ -1417,7 +1417,7 @@ void matroska_segment_c::ParseChapterAtom( int i_level, KaxChapterAtom *ca, chap
         E_CASE( KaxChapterTimeEnd, end )
         {
             vars.chapters.i_end_time = VLC_TICK_FROM_NS(static_cast<uint64_t>( end ));
-            debug( vars, "ChapterTimeEnd=%" PRId64, vars.chapters.i_end_time );
+            debug( vars, "ChapterTimeEnd=%" PRId64, *vars.chapters.i_end_time );
         }
         E_CASE( KaxChapterDisplay, chapter_display )
         {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ee8620572a984a9fbc466a0e2d0cf599f28866bd

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ee8620572a984a9fbc466a0e2d0cf599f28866bd
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance