[vlc-commits] [Git][videolan/vlc][master] Qt: fix redundant comparison in hotkey preferences

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
cab07182 by YosfKenawy at 2026-02-13T14:45:01+00:00
Qt: fix redundant comparison in hotkey preferences

This addresses Coverity CID 1665807. Fixes #29366

- - - - -


1 changed file:

- modules/gui/qt/dialogs/preferences/preferences_widgets.cpp


Changes:

=====================================
modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
=====================================
@@ -1555,7 +1555,7 @@ void KeySelectorControl::tableContextMenuEvent( QWidget *widget, QContextMenuEve
     {
         case ACTION_COL:
             empty = (item->normal.keys.isEmpty() && item->global.keys.isEmpty());
-            matches_default = (item->normal.matches_default && item->normal.matches_default);
+            matches_default = (item->normal.matches_default && item->global.matches_default);
             break;
         case HOTKEY_COL:
             empty = item->normal.keys.isEmpty();



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cab07182b66e7512adf1655dc3a126b92024ad75

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cab07182b66e7512adf1655dc3a126b92024ad75
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance