[vlc-commits] [Git][videolan/vlc][master] 2 commits: qt: fix messages filter restore

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
7f9e0d17 by Marvin Scholz at 2026-01-26T12:54:42+00:00
qt: fix messages filter restore

The messages filter group must not be translated, it makes no sense to
translate setting keys. In this case it was especially problematic as it
was only done when reading but not when writing the setting, resulting
in inconsistent UI state depending on the language of the user.

- - - - -
2deb1c14 by Marvin Scholz at 2026-01-26T12:54:42+00:00
qt: messages: do not use {begin,end}Group

It is simpler to just put the Group into the settings key directly,
especially as it is only a singular key here, so the begin/endGroup
calls add more lines than they save repeating the Messages prefix.

- - - - -


1 changed file:

- modules/gui/qt/dialogs/messages/messages.cpp


Changes:

=====================================
modules/gui/qt/dialogs/messages/messages.cpp
=====================================
@@ -100,9 +100,7 @@ MessagesDialog::MessagesDialog( qt_intf_t *_p_intf)
     changeVerbosity( i_verbosity );
     ui.verbosityBox->setValue( qMin( i_verbosity, 2 ) );
 
-    getSettings()->beginGroup( qtr("Messages") );
-    ui.filterEdit->setText( getSettings()->value( "messages-filter" ).toString() );
-    getSettings()->endGroup();
+    ui.filterEdit->setText( getSettings()->value( "Messages/messages-filter" ).toString() );
 
     updateButton = new QToolButton;
     updateButton->setIcon( QIcon(":/menu/update.svg") );
@@ -165,9 +163,7 @@ void MessagesDialog::changeVerbosity( int i_verbosity )
 
 void MessagesDialog::updateConfig()
 {
-    getSettings()->beginGroup( "Messages" );
-    getSettings()->setValue( "messages-filter", ui.filterEdit->text() );
-    getSettings()->endGroup();
+    getSettings()->setValue( "Messages/messages-filter", ui.filterEdit->text() );
 }
 
 void MessagesDialog::addError(int row){



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/18bf5447acb6dbfa6d7db28ede7809406e983904...2deb1c14e901605399b9b2f7b48bbc1a8eaadcc5

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/18bf5447acb6dbfa6d7db28ede7809406e983904...2deb1c14e901605399b9b2f7b48bbc1a8eaadcc5
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance