[vlc-commits] [Git][videolan/vlc][master] macosx: Make IBOutlet properties that do not need to be strong weak
Steve Lhomme (@robUx4)
gitlab at videolan.org
Tue Jul 7 06:38:33 UTC 2026
Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
3ffffb8e by Claudio Cambra at 2026-07-07T06:25:51+00:00
macosx: Make IBOutlet properties that do not need to be strong weak
Signed-off-by: Claudio Cambra <developer at claudiocambra.com>
# Conflicts:
# modules/gui/macosx/windows/controlsbar/VLCControlsBarCommon.h
- - - - -
7 changed files:
- modules/gui/macosx/library/VLCLibraryWindow.h
- modules/gui/macosx/menus/VLCMainMenu.h
- modules/gui/macosx/panels/dialogs/VLCResumeDialogController.h
- modules/gui/macosx/windows/controlsbar/VLCControlsBarCommon.h
- modules/gui/macosx/windows/controlsbar/VLCMainWindowControlsBar.h
- modules/gui/macosx/windows/video/VLCMainVideoViewAudioMediaDecorativeView.h
- modules/gui/macosx/windows/video/VLCMainVideoViewController.h
Changes:
=====================================
modules/gui/macosx/library/VLCLibraryWindow.h
=====================================
@@ -111,9 +111,9 @@ extern NSString * const VLCLibraryWindowEmbeddedVideoPlaybackActiveKey;
@property (readwrite, weak) IBOutlet VLCLibraryWindowToolbarDelegate *toolbarDelegate;
@property (nonatomic, readwrite, strong) IBOutlet NSView *emptyLibraryView;
- at property (nonatomic, readwrite, strong) IBOutlet NSImageView *placeholderImageView;
- at property (nonatomic, readwrite, strong) IBOutlet NSTextField *placeholderLabel;
- at property (nonatomic, readwrite, strong) IBOutlet VLCCustomEmptyLibraryBrowseButton *placeholderGoToBrowseButton;
+ at property (nonatomic, readwrite, weak) IBOutlet NSImageView *placeholderImageView;
+ at property (nonatomic, readwrite, weak) IBOutlet NSTextField *placeholderLabel;
+ at property (nonatomic, readwrite, weak) IBOutlet VLCCustomEmptyLibraryBrowseButton *placeholderGoToBrowseButton;
@property (readonly) VLCLoadingOverlayView *loadingOverlayView;
@property (readonly) NSArray<NSLayoutConstraint *> *placeholderImageViewConstraints;
=====================================
modules/gui/macosx/menus/VLCMainMenu.h
=====================================
@@ -208,23 +208,23 @@
/* vout menu */
@property (readwrite, strong) IBOutlet NSMenu *voutMenu;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuplay;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenustop;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuRecord;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuprev;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenunext;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuvolup;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuvoldown;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenumute;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuAudiotrack;
- at property (readwrite, strong) IBOutlet NSMenu *voutMenuAudiotrackMenu;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuVideotrack;
- at property (readwrite, strong) IBOutlet NSMenu *voutMenuVideotrackMenu;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuOpenSubtitleFile;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenuSubtitlestrack;
- at property (readwrite, strong) IBOutlet NSMenu *voutMenuSubtitlestrackMenu;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenufullscreen;
- at property (readwrite, strong) IBOutlet NSMenuItem *voutMenusnapshot;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuplay;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenustop;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuRecord;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuprev;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenunext;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuvolup;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuvoldown;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenumute;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuAudiotrack;
+ at property (readwrite, weak) IBOutlet NSMenu *voutMenuAudiotrackMenu;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuVideotrack;
+ at property (readwrite, weak) IBOutlet NSMenu *voutMenuVideotrackMenu;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuOpenSubtitleFile;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenuSubtitlestrack;
+ at property (readwrite, weak) IBOutlet NSMenu *voutMenuSubtitlestrackMenu;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenufullscreen;
+ at property (readwrite, weak) IBOutlet NSMenuItem *voutMenusnapshot;
@property (readwrite, strong) IBOutlet NSView *playlistSaveAccessoryView;
@property (readwrite, weak) IBOutlet NSPopUpButton *playlistSaveAccessoryPopup;
=====================================
modules/gui/macosx/panels/dialogs/VLCResumeDialogController.h
=====================================
@@ -35,11 +35,11 @@ typedef void(^CompletionBlock)(enum ResumeResult);
@interface VLCResumeDialogController : NSWindowController
- at property (readwrite, strong) IBOutlet NSTextField *titleLabel;
- at property (readwrite, strong) IBOutlet NSTextField *descriptionLabel;
- at property (readwrite, strong) IBOutlet NSButton *restartButton;
- at property (readwrite, strong) IBOutlet NSButton *resumeButton;
- at property (readwrite, strong) IBOutlet NSButton *alwaysResumeCheckbox;
+ at property (readwrite, weak) IBOutlet NSTextField *titleLabel;
+ at property (readwrite, weak) IBOutlet NSTextField *descriptionLabel;
+ at property (readwrite, weak) IBOutlet NSButton *restartButton;
+ at property (readwrite, weak) IBOutlet NSButton *resumeButton;
+ at property (readwrite, weak) IBOutlet NSButton *alwaysResumeCheckbox;
- (IBAction)buttonClicked:(id)sender;
- (IBAction)resumeSettingChanged:(id)sender;
=====================================
modules/gui/macosx/windows/controlsbar/VLCControlsBarCommon.h
=====================================
@@ -39,37 +39,37 @@
@interface VLCControlsBarCommon : NSObject
- at property (readwrite, strong) IBOutlet VLCDragDropView *dropView;
+ at property (readwrite, weak) IBOutlet VLCDragDropView *dropView;
- at property (readwrite, strong) IBOutlet NSButton *playButton;
- at property (readwrite, strong) IBOutlet NSButton *backwardButton;
- at property (readwrite, strong) IBOutlet NSButton *forwardButton;
- at property (readwrite, strong) IBOutlet NSButton *jumpBackwardButton;
- at property (readwrite, strong) IBOutlet NSButton *jumpForwardButton;
+ at property (readwrite, weak) IBOutlet NSButton *playButton;
+ at property (readwrite, weak) IBOutlet NSButton *backwardButton;
+ at property (readwrite, weak) IBOutlet NSButton *forwardButton;
+ at property (readwrite, weak) IBOutlet NSButton *jumpBackwardButton;
+ at property (readwrite, weak) IBOutlet NSButton *jumpForwardButton;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *jumpBackwardButtonWidthConstraint;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *jumpForwardButtonWidthConstraint;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *jumpBackwardButtonSpacingConstraint;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *jumpForwardButtonSpacingConstraint;
- at property (readwrite, strong) IBOutlet VLCPlaybackProgressSlider *timeSlider;
- at property (readwrite, strong) IBOutlet VLCVolumeSlider *volumeSlider;
- at property (readwrite, strong) IBOutlet NSButton *muteVolumeButton;
+ at property (readwrite, weak) IBOutlet VLCPlaybackProgressSlider *timeSlider;
+ at property (readwrite, weak) IBOutlet VLCVolumeSlider *volumeSlider;
+ at property (readwrite, weak) IBOutlet NSButton *muteVolumeButton;
- at property (readwrite, strong) IBOutlet VLCImageView *artworkImageView;
- at property (readwrite, strong) IBOutlet NSButton *artworkButton;
- at property (readwrite, strong) IBOutlet NSTextField *playingItemDisplayField;
- at property (readwrite, strong) IBOutlet NSTextField *detailLabel;
- at property (readwrite, strong) IBOutlet VLCTimeField *timeField;
- at property (readwrite, strong) IBOutlet VLCTimeField *trailingTimeField;
+ at property (readwrite, weak) IBOutlet VLCImageView *artworkImageView;
+ at property (readwrite, weak) IBOutlet NSButton *artworkButton;
+ at property (readwrite, weak) IBOutlet NSTextField *playingItemDisplayField;
+ at property (readwrite, weak) IBOutlet NSTextField *detailLabel;
+ at property (readwrite, weak) IBOutlet VLCTimeField *timeField;
+ at property (readwrite, weak) IBOutlet VLCTimeField *trailingTimeField;
- at property (readwrite, strong) IBOutlet NSButton *fullscreenButton;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *fullscreenButtonWidthConstraint;
+ at property (readwrite, weak) IBOutlet NSButton *fullscreenButton;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *fullscreenButtonWidthConstraint;
- at property (readwrite, strong) IBOutlet NSButton *pipButton;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *pipButtonWidthConstraint;
+ at property (readwrite, weak) IBOutlet NSButton *pipButton;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *pipButtonWidthConstraint;
- at property (readwrite, strong) IBOutlet VLCBottomBarView *bottomBarView;
+ at property (readwrite, weak) IBOutlet VLCBottomBarView *bottomBarView;
@property (readonly) BOOL nativeFullscreenMode;
=====================================
modules/gui/macosx/windows/controlsbar/VLCMainWindowControlsBar.h
=====================================
@@ -36,15 +36,15 @@
@interface VLCMainWindowControlsBar : VLCControlsBarCommon
- at property (readwrite, strong) IBOutlet NSButton *stopButton;
- at property (readwrite, strong) IBOutlet NSButton *prevButton;
- at property (readwrite, strong) IBOutlet NSButton *nextButton;
- at property (readwrite, strong) IBOutlet NSButton *volumeUpButton;
- at property (readwrite, strong) IBOutlet NSButton *favoriteButton;
-
- at property (readwrite, strong) IBOutlet VLCTrackingView *thumbnailTrackingView;
- at property (readwrite, strong) IBOutlet NSView *openMainVideoViewButtonOverlay;
- at property (readwrite, strong) IBOutlet NSVisualEffectView *visualEffectView;
+ at property (readwrite, weak) IBOutlet NSButton *stopButton;
+ at property (readwrite, weak) IBOutlet NSButton *prevButton;
+ at property (readwrite, weak) IBOutlet NSButton *nextButton;
+ at property (readwrite, weak) IBOutlet NSButton *volumeUpButton;
+ at property (readwrite, weak) IBOutlet NSButton *favoriteButton;
+
+ at property (readwrite, weak) IBOutlet VLCTrackingView *thumbnailTrackingView;
+ at property (readwrite, weak) IBOutlet NSView *openMainVideoViewButtonOverlay;
+ at property (readwrite, weak) IBOutlet NSVisualEffectView *visualEffectView;
- (IBAction)stop:(id)sender;
- (IBAction)toggleFavorite:(id)sender;
=====================================
modules/gui/macosx/windows/video/VLCMainVideoViewAudioMediaDecorativeView.h
=====================================
@@ -26,10 +26,10 @@ NS_ASSUME_NONNULL_BEGIN
@interface VLCMainVideoViewAudioMediaDecorativeView : NSView
- at property (readwrite, strong) IBOutlet NSImageView *foregroundCoverArtView;
- at property (readwrite, strong) IBOutlet NSImageView *backgroundCoverArtView;
- at property (readwrite, strong) IBOutlet NSVisualEffectView *backgroundVisualEffectView;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *foregroundViewTopConstraint;
+ at property (readwrite, weak) IBOutlet NSImageView *foregroundCoverArtView;
+ at property (readwrite, weak) IBOutlet NSImageView *backgroundCoverArtView;
+ at property (readwrite, weak) IBOutlet NSVisualEffectView *backgroundVisualEffectView;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *foregroundViewTopConstraint;
@property (readwrite, weak) IBOutlet NSScrollView *lyricsScrollView;
@property (readwrite, weak) IBOutlet NSTableView *lyricsTableView;
=====================================
modules/gui/macosx/windows/video/VLCMainVideoViewController.h
=====================================
@@ -35,26 +35,26 @@ extern NSString * const VLCUseClassicVideoPlayerLayoutKey;
@interface VLCMainVideoViewController : NSViewController
- at property (readwrite, strong) IBOutlet NSView *voutContainingView;
+ at property (readwrite, weak) IBOutlet NSView *voutContainingView;
- at property (readwrite, strong) IBOutlet VLCVoutView *voutView;
- at property (readwrite, strong) IBOutlet NSBox *mainControlsView;
- at property (readwrite, strong) IBOutlet VLCMainVideoViewOverlayView *overlayView;
- at property (readwrite, strong) IBOutlet NSView *bottomBarView;
- at property (readwrite, strong) IBOutlet NSStackView *centralControlsStackView;
+ at property (readwrite, weak) IBOutlet VLCVoutView *voutView;
+ at property (readwrite, weak) IBOutlet NSBox *mainControlsView;
+ at property (readwrite, weak) IBOutlet VLCMainVideoViewOverlayView *overlayView;
+ at property (readwrite, weak) IBOutlet NSView *bottomBarView;
+ at property (readwrite, weak) IBOutlet NSStackView *centralControlsStackView;
@property (readwrite, strong) IBOutlet VLCMainVideoViewControlsBar *controlsBar;
- at property (readwrite, strong) IBOutlet NSButton *returnButton;
- at property (readwrite, strong) IBOutlet NSButton *playQueueButton;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *returnButtonTopConstraint;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *returnButtonLeadingConstraint;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *playQueueButtonTopConstraint;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *playQueueButtonTrailingConstraint;
+ at property (readwrite, weak) IBOutlet NSButton *returnButton;
+ at property (readwrite, weak) IBOutlet NSButton *playQueueButton;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *returnButtonTopConstraint;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *returnButtonLeadingConstraint;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *playQueueButtonTopConstraint;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *playQueueButtonTrailingConstraint;
@property (readwrite, strong) IBOutlet NSLayoutConstraint *videoViewBottomConstraint;
- at property (readwrite, strong) IBOutlet NSVisualEffectView *fakeTitleBar;
- at property (readwrite, strong) IBOutlet NSLayoutConstraint *fakeTitleBarHeightConstraint;
- at property (readwrite, strong) IBOutlet NSProgressIndicator *loadingIndicator;
- at property (readwrite, strong) IBOutlet NSImageView *floatOnTopIndicatorImageView;
- at property (readwrite, strong) IBOutlet NSView *classicViewBottomBarContainerView;
+ at property (readwrite, weak) IBOutlet NSVisualEffectView *fakeTitleBar;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *fakeTitleBarHeightConstraint;
+ at property (readwrite, weak) IBOutlet NSProgressIndicator *loadingIndicator;
+ at property (readwrite, weak) IBOutlet NSImageView *floatOnTopIndicatorImageView;
+ at property (readwrite, weak) IBOutlet NSView *classicViewBottomBarContainerView;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *playButtonSizeConstraint;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *prevButtonSizeConstraint;
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3ffffb8e61e19129a8702b5ee4946402c94a6a54
--
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3ffffb8e61e19129a8702b5ee4946402c94a6a54
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help
More information about the vlc-commits
mailing list