[vlc-commits] [Git][videolan/vlc][master] qml: fix handle and background positioning in `VolumeWidget`

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
91b90455 by Fatih Uzunoglu at 2026-07-16T11:32:10+00:00
qml: fix handle and background positioning in `VolumeWidget`

This seems to be a Qt bug, but we can simply use `Binding`
as a workaround.

- - - - -


1 changed file:

- modules/gui/qt/player/qml/controlbarcontrols/VolumeWidget.qml


Changes:

=====================================
modules/gui/qt/player/qml/controlbarcontrols/VolumeWidget.qml
=====================================
@@ -96,8 +96,15 @@ T.Pane {
             // FIXME: use VLCStyle
             implicitWidth: VLCStyle.dp(100, VLCStyle.scale)
 
-            topInset: MainCtx.usingTouch ? VLCStyle.touchHandlerMargin : 0.0 /* implicitTopInset */
-            bottomInset: MainCtx.usingTouch ? VLCStyle.touchHandlerMargin : 0.0 /* implicitTopInset */
+            // WARNING: Directly setting the insets break handle and background positioning.
+            Binding on topInset {
+                when: MainCtx.usingTouch
+                value: VLCStyle.touchHandlerMargin
+            }
+            Binding on bottomInset {
+                when: MainCtx.usingTouch
+                value: VLCStyle.touchHandlerMargin
+            }
 
             Layout.fillHeight: true
             Layout.margins: VLCStyle.margin_xsmall



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/91b90455f0fd0ca4e295e7613ce267f4c27d6e16

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/91b90455f0fd0ca4e295e7613ce267f4c27d6e16
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help