[vlc-commits] [Git][videolan/vlc][master] qml: debug: get rid of painted size comparison in `ImageExt`

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
6d6a801b by Fatih Uzunoglu at 2026-07-17T08:15:04+00:00
qml: debug: get rid of painted size comparison in `ImageExt`

Although painted size calculation is based on `QQuickImage`,
it appears that we deviate slightly from how it does, yet
the `ShaderEffect` is happy with our calculation.

Note that this check was already obsolete for `PreserveAspectCrop`
mode, because we handle it totally different than `QQuickImage`.

This change fixes debug message being spammed while scrolling
in various views.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/ImageExt.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/ImageExt.qml
=====================================
@@ -260,16 +260,6 @@ Item {
                 ret.height = root.height
             }
 
-            /// <debug>
-            // Debug only, we use our calculation for reliability regardless of the source:
-            if (source === image) {
-               if (image.paintedWidth !== ret.width || source.paintedHeight !== ret.height) {
-                   console.debug(root, "painted sizes of the default texture provider and the calculation differ: (%1, %2), (%3, %4)"
-                                       .arg(image.paintedWidth).arg(image.paintedHeight).arg(ret.width).arg(ret.height))
-               }
-            }
-            /// </debug>
-
             return ret
         }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6d6a801b7d1861d57522625fc491c5cc7511751a

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6d6a801b7d1861d57522625fc491c5cc7511751a
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help