[vlc-commits] [Git][videolan/vlc][master] 2 commits: macosx: Fix visibility of forward/backward buttons in classic main video view
Steve Lhomme (@robUx4)
gitlab at videolan.org
Fri Jul 17 09:39:11 UTC 2026
Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
0220e5b1 by Claudio Cambra at 2026-07-17T09:04:32+00:00
macosx: Fix visibility of forward/backward buttons in classic main video view
Signed-off-by: Claudio Cambra <developer at claudiocambra.com>
- - - - -
181365a5 by Claudio Cambra at 2026-07-17T09:04:32+00:00
macosx: Fix hiding of jump forwards/backwards buttons in classic main video view
Signed-off-by: Claudio Cambra <developer at claudiocambra.com>
- - - - -
3 changed files:
- modules/gui/macosx/UI/VLCClassicMainVideoView.xib
- modules/gui/macosx/views/VLCUIUnits.m
- modules/gui/macosx/windows/controlsbar/VLCControlsBarCommon.m
Changes:
=====================================
modules/gui/macosx/UI/VLCClassicMainVideoView.xib
=====================================
@@ -33,11 +33,16 @@
<customObject id="3" userLabel="Main Video View Controls Bar" customClass="VLCMainVideoViewControlsBar">
<connections>
<outlet property="backwardButton" destination="GVj-Mw-yGh" id="r8R-h9-hIN"/>
+ <outlet property="bottomBarView" destination="qsP-dd-T9O" id="WqX-SW-mpv"/>
<outlet property="floatOnTopButton" destination="UlM-pV-GAH" id="Psy-2Z-suK"/>
<outlet property="forwardButton" destination="Udx-ZV-vdD" id="ILc-3U-3Lg"/>
<outlet property="fullscreenButton" destination="Dka-oG-Ar0" id="nqz-qB-etE"/>
<outlet property="jumpBackwardButton" destination="Y6X-Qj-wAU" id="ZDb-ZR-IDF"/>
+ <outlet property="jumpBackwardButtonSpacingConstraint" destination="LnZ-my-zBM" id="jbs-sp-c"/>
+ <outlet property="jumpBackwardButtonWidthConstraint" destination="O5b-gT-vco" id="jbw-w-c"/>
<outlet property="jumpForwardButton" destination="omu-it-6Lt" id="gtC-uD-Mnu"/>
+ <outlet property="jumpForwardButtonSpacingConstraint" destination="dmg-RC-IOH" id="jfs-sp-c"/>
+ <outlet property="jumpForwardButtonWidthConstraint" destination="14N-xJ-2Kx" id="jfw-w-c"/>
<outlet property="lyricsButton" destination="Lyr-Ics-Btn" id="Lyr-Ics-Out"/>
<outlet property="muteVolumeButton" destination="x8O-Jz-KS8" id="lIH-Am-21m"/>
<outlet property="pipButton" destination="ha3-L8-lMU" id="nqJ-hd-8M1"/>
@@ -147,6 +152,9 @@
</box>
<button verticalHuggingPriority="1000" translatesAutoresizingMaskIntoConstraints="NO" id="Y6X-Qj-wAU" customClass="VLCImageButton">
<rect key="frame" x="5" y="5" width="48" height="28"/>
+ <constraints>
+ <constraint firstAttribute="width" constant="48" id="O5b-gT-vco"/>
+ </constraints>
<shadow key="shadow" blurRadius="20">
<color key="color" white="0.0" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
</shadow>
@@ -206,6 +214,9 @@
</button>
<button verticalHuggingPriority="1000" translatesAutoresizingMaskIntoConstraints="NO" id="omu-it-6Lt" customClass="VLCImageButton">
<rect key="frame" x="215" y="5" width="48" height="28"/>
+ <constraints>
+ <constraint firstAttribute="width" constant="48" id="14N-xJ-2Kx"/>
+ </constraints>
<shadow key="shadow" blurRadius="20">
<color key="color" white="0.0" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
</shadow>
@@ -364,7 +375,6 @@
</stackView>
</subviews>
<constraints>
- <constraint firstItem="omu-it-6Lt" firstAttribute="width" secondItem="Udx-ZV-vdD" secondAttribute="width" id="14N-xJ-2Kx"/>
<constraint firstAttribute="bottom" secondItem="Y6X-Qj-wAU" secondAttribute="bottom" constant="4" id="16E-Ua-ogn" customClass="VLCSpacingConstraint">
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="number" keyPath="spacingToken">
@@ -391,14 +401,7 @@
</constraint>
<constraint firstItem="GVj-Mw-yGh" firstAttribute="centerY" secondItem="qsP-dd-T9O" secondAttribute="centerY" id="Ftz-rq-HO8"/>
<constraint firstItem="omu-it-6Lt" firstAttribute="centerY" secondItem="qsP-dd-T9O" secondAttribute="centerY" id="H4i-40-eS4"/>
- <constraint firstItem="Y6X-Qj-wAU" firstAttribute="leading" secondItem="qsP-dd-T9O" secondAttribute="leading" constant="4" id="LnZ-my-zBM" customClass="VLCSpacingConstraint">
- <userDefinedRuntimeAttributes>
- <userDefinedRuntimeAttribute type="number" keyPath="spacingToken">
- <integer value="1"/>
- </userDefinedRuntimeAttribute>
- </userDefinedRuntimeAttributes>
- </constraint>
- <constraint firstItem="Y6X-Qj-wAU" firstAttribute="width" secondItem="GVj-Mw-yGh" secondAttribute="width" id="O5b-gT-vco"/>
+ <constraint firstItem="Y6X-Qj-wAU" firstAttribute="leading" secondItem="qsP-dd-T9O" secondAttribute="leading" constant="5" id="LnZ-my-zBM"/>
<constraint firstItem="GVj-Mw-yGh" firstAttribute="height" secondItem="etJ-bh-XaL" secondAttribute="height" id="OZ1-nq-sPB"/>
<constraint firstItem="Udx-ZV-vdD" firstAttribute="leading" secondItem="etJ-bh-XaL" secondAttribute="trailing" constant="4" id="P9A-Tb-eJJ" customClass="VLCSpacingConstraint">
<userDefinedRuntimeAttributes>
=====================================
modules/gui/macosx/views/VLCUIUnits.m
=====================================
@@ -332,7 +332,7 @@ NSString * const VLCLibraryCollectionViewItemAdjustmentKey = @"VLCLibraryCollect
+ (const CGFloat)libraryWindowControlsBarNarrowWidthThreshold
{
- return 600.;
+ return 768.;
}
+ (const CGFloat)libraryWindowNavSidebarMinWidth
=====================================
modules/gui/macosx/windows/controlsbar/VLCControlsBarCommon.m
=====================================
@@ -278,12 +278,12 @@
_jumpBackwardButtonOriginalSpacing = self.jumpBackwardButtonSpacingConstraint.constant;
_jumpForwardButtonOriginalSpacing = self.jumpForwardButtonSpacingConstraint.constant;
- self.dropView.postsFrameChangedNotifications = YES;
+ self.bottomBarView.postsFrameChangedNotifications = YES;
[NSNotificationCenter.defaultCenter addObserver:self
- selector:@selector(dropViewFrameChanged:)
+ selector:@selector(bottomBarViewFrameChanged:)
name:NSViewFrameDidChangeNotification
- object:self.dropView];
- [self updateJumpButtonVisibilityForWidth:self.dropView.frame.size.width];
+ object:self.bottomBarView];
+ [self updateJumpButtonVisibilityForWidth:self.bottomBarView.frame.size.width];
}
- (void)dealloc
@@ -291,9 +291,9 @@
[NSNotificationCenter.defaultCenter removeObserver:self];
}
-- (void)dropViewFrameChanged:(NSNotification *)notification
+- (void)bottomBarViewFrameChanged:(NSNotification *)notification
{
- [self updateJumpButtonVisibilityForWidth:self.dropView.frame.size.width];
+ [self updateJumpButtonVisibilityForWidth:self.bottomBarView.frame.size.width];
}
- (void)updateJumpButtonVisibilityForWidth:(CGFloat)width
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/14b145e17b23f3620d4f8c508fdb422ff399ba28...181365a502ce53e29a6b52807e46e03f588f33d0
--
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/14b145e17b23f3620d4f8c508fdb422ff399ba28...181365a502ce53e29a6b52807e46e03f588f33d0
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help
More information about the vlc-commits
mailing list