[vlc-commits] [Git][videolan/vlc][master] qt: fix initial position and text adjustment in `PointingToolTipAttached`
Felix Paul Kühne (@fkuehne)
gitlab at videolan.org
Mon Jul 27 15:38:24 UTC 2026
Felix Paul Kühne pushed to branch master at VideoLAN / VLC
Commits:
5a6856d2 by Fatih Uzunoglu at 2026-07-27T17:26:42+02:00
qt: fix initial position and text adjustment in `PointingToolTipAttached`
Since both `setPos()` and `setText()` adjust the effective values when
`::instanceBoundToParent()` returns `true`, we should first adjust the
parent before calling them.
- - - - -
1 changed file:
- modules/gui/qt/util/pointingtooltipattached.hpp
Changes:
=====================================
modules/gui/qt/util/pointingtooltipattached.hpp
=====================================
@@ -126,9 +126,6 @@ public:
// Akin to `QQuickToolTipAttached`:
if (visible)
{
- setPos(m_pos);
- setText(m_text);
-
if (!m_parentProperty)
m_parentProperty = QQmlProperty(m_instance, QStringLiteral("parent"));
@@ -136,6 +133,9 @@ public:
m_parentProperty->write(QVariant::fromValue(qobject_cast<QQuickItem*>(parent())));
+ setPos(m_pos);
+ setText(m_text);
+
m_visibleProperty->write(true);
}
else
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/5a6856d20d0d288ec2b47f9f6bebeea75c615dae
--
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/5a6856d20d0d288ec2b47f9f6bebeea75c615dae
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help
More information about the vlc-commits
mailing list