[vlc-commits] [Git][videolan/vlc][3.0.x] contrib: harfbuzz: Avoid a warning as error on Clang 23

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
e3131e16 by Martin Storsjö at 2026-07-29T12:00:18+00:00
contrib: harfbuzz: Avoid a warning as error on Clang 23

Harfbuzz enables a number of warnings as errors, by default,
through pragmas in a header.

Newer versions of compilers can emit warnings where none
were emitted before, so to avoid running into errors with newer
toolchains, disable making the warnings errors.

In particular, a recent change in Clang (included since Clang 23)
caused Harfbuzz to produce warnings about unused function
templates, see https://github.com/harfbuzz/harfbuzz/issues/6059.

This backports upstream commits 5e887d36722abfef1c02a11ab15a369d7745027e
and b011381764f87be3cdd57b9a3205a51064016bba to avoid this warning
as error.

(cherry picked from commit ced16aa8bc380567b8f95c9d584c128574753ddc)

- - - - -


2 changed files:

- + contrib/src/harfbuzz/0001-Ignore-Wunused-template.patch
- contrib/src/harfbuzz/rules.mak


Changes:

=====================================
contrib/src/harfbuzz/0001-Ignore-Wunused-template.patch
=====================================
@@ -0,0 +1,29 @@
+From 0f364b57dc7c7e41e22d5bc6407b5c2f603694fa Mon Sep 17 00:00:00 2001
+From: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu, 9 Jul 2026 12:09:01 -0600
+Subject: [PATCH] Ignore -Wunused-template
+
+Fixes https://github.com/harfbuzz/harfbuzz/issues/6059
+
+This is squashed from upstream commits
+5e887d36722abfef1c02a11ab15a369d7745027e and
+b011381764f87be3cdd57b9a3205a51064016bba.
+---
+ src/hb.hh | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/hb.hh b/src/hb.hh
+index 7e2837f99..5d7c45c79 100644
+--- a/src/hb.hh
++++ b/src/hb.hh
+@@ -151,6 +151,7 @@
+ #pragma GCC diagnostic ignored "-Wrange-loop-analysis" // https://github.com/harfbuzz/harfbuzz/issues/2834
+ #pragma GCC diagnostic ignored "-Wstrict-aliasing"
+ #pragma GCC diagnostic ignored "-Wtype-limits"
++#pragma GCC diagnostic ignored "-Wunused-template"
+ #pragma GCC diagnostic ignored "-Wc++11-compat" // only gcc raises it
+ #endif
+ 
+-- 
+2.43.0
+


=====================================
contrib/src/harfbuzz/rules.mak
=====================================
@@ -15,6 +15,7 @@ $(TARBALLS)/harfbuzz-$(HARFBUZZ_VERSION).tar.xz:
 harfbuzz: harfbuzz-$(HARFBUZZ_VERSION).tar.xz .sum-harfbuzz
 	$(UNPACK)
 	$(APPLY) $(SRC)/harfbuzz/0001-disable-building-hb-gpu-encode-all-app.patch
+	$(APPLY) $(SRC)/harfbuzz/0001-Ignore-Wunused-template.patch
 	$(MOVE)
 
 DEPS_harfbuzz = freetype2 $(DEPS_freetype2) png $(DEPS_png)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e3131e1649426de8d23c8f76b39e81c2606bd43f

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e3131e1649426de8d23c8f76b39e81c2606bd43f
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help