[vlc-commits] [Git][videolan/vlc][master] qt: enable the style combo box on Windows in simple preferences dialog

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
ca464193 by Fatih Uzunoglu at 2026-06-03T18:37:58+02:00
qt: enable the style combo box on Windows in simple preferences dialog

In 3.0 branch, the combo box is enabled on
Windows with the introduction of dark mode
setting. Since 4.0 branch applies the style
regardless of the system, we should enable
the style combo box as not doing so may make
4.0 look unintended (for example the user
sets WindowsVista style in 3.0, but Qt now
has ModernWindowsStyle which is the default
style).

Note that this is only relevant for Qt Widgets
and not for Qt Quick.

- - - - -


1 changed file:

- modules/gui/qt/dialogs/preferences/simple_preferences.cpp


Changes:

=====================================
modules/gui/qt/dialogs/preferences/simple_preferences.cpp
=====================================
@@ -751,7 +751,6 @@ SPrefsPanel::SPrefsPanel( qt_intf_t *_p_intf, QWidget *_parent,
                 free( psz_intf );
             }
 
-#if !defined( _WIN32)
             {
                 // Populate styles combobox:
                 assert(qApp->property("initialStyle").isValid());
@@ -775,10 +774,7 @@ SPrefsPanel::SPrefsPanel( qt_intf_t *_p_intf, QWidget *_parent,
 
             connect( ui.stylesCombo, QOverload<int>::of(&QComboBox::currentIndexChanged),
                      this, &SPrefsPanel::changeStyle );
-#else
-            ui.stylesCombo->hide();
-            ui.stylesLabel->hide();
-#endif
+
             radioGroup = new QButtonGroup(this);
             radioGroup->addButton( ui.modernButton, 0 );
             radioGroup->addButton( ui.classicButton, 1 );



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ca464193aa9f8e9f01cfbfbaf2e9221f427a56d0

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ca464193aa9f8e9f01cfbfbaf2e9221f427a56d0
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help