[vlc-commits] [Git][videolan/vlc][3.0.x] avcodec: chroma: fix chroma id return value

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
8ffca711 by Alaric Senat at 2026-06-04T10:25:15+00:00
avcodec: chroma: fix chroma id return value

This fixes a regression from faf9f526c9ba3fe3cda8dc12f48d0cc12cfb5ea1,
where the backport assumed that the function returned a chroma ID. While
this is the case in 4.0, VLC 3.0 still returns an error code and fills
a param return value directly.

This was caught by the Medialibrary CI with the latest 3.0.x branch.

- - - - -


1 changed file:

- modules/codec/avcodec/chroma.c


Changes:

=====================================
modules/codec/avcodec/chroma.c
=====================================
@@ -204,7 +204,8 @@ int GetFfmpegChroma( int *restrict i_ffmpeg_chroma, const video_format_t *fmt )
             chroma_table[i].i_gmask  == fmt->i_gmask &&
             chroma_table[i].i_bmask  == fmt->i_bmask )
         {
-            return chroma_table[i].i_chroma_id;
+            *i_ffmpeg_chroma = chroma_table[i].i_chroma_id;
+            return VLC_SUCCESS;
         }
     }
     // try again without the mask as they may not correspond exactly



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8ffca71177fc753c8ed914e93cb875353c124fac

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8ffca71177fc753c8ed914e93cb875353c124fac
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help