[vlc-commits] [Git][videolan/vlc][master] Partial revert "contrib: qt: strip installed static libraries with gcc+win32"

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
094833f7 by Fatih Uzunoglu at 2026-06-16T05:04:40+00:00
Partial revert "contrib: qt: strip installed static libraries with gcc+win32"

Although the comment is right, we apparently don't
need to do the same in both `qtbase` and `qtdeclarative`.

In my case, if `qtbase` has debug information, the size
of `libqt_plugin.dll` ends up being about 1 GB, which
is not big enough for `LoadLibrary()` to fail.

This helps debugging with Wine (winedbg) or MinGW gdb.

This partially reverts commit ee57b63e13f31e2afecf7e57b165f1db3aea89a4.

- - - - -


1 changed file:

- contrib/src/qt/rules.mak


Changes:

=====================================
contrib/src/qt/rules.mak
=====================================
@@ -79,16 +79,6 @@ QTBASE_CONFIG += -DFEATURE_style_fusion=OFF
 QTBASE_CONFIG += -DFEATURE_direct2d=ON -DFEATURE_direct2d1_1=OFF
 endif
 
-QTBASE_HOSTVARS = $(HOSTVARS_CMAKE)
-ifdef HAVE_WIN32
-ifndef HAVE_CLANG
-# gcc doesn't support PDBs and therefore keep a huge amount of debug information
-# this can result in libqt_plugin.dll being bigger than 2GB (#28643).
-QTBASE_CONFIG += -DCMAKE_CXX_FLAGS_DEBUG:STRING= -DCMAKE_C_FLAGS_DEBUG:STRING= -DCMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING= -DCMAKE_C_FLAGS_RELWITHDEBINFO:STRING=
-QTBASE_HOSTVARS += CXXFLAGS="$(patsubst -g,,${CXXFLAGS})" CFLAGS="$(patsubst -g,,${CFLAGS})"
-endif
-endif
-
 QTBASE_COMMON_CONFIG := -DFEATURE_pkg_config=OFF -DINPUT_openssl=no \
 	-DFEATURE_dbus=OFF -DFEATURE_zstd=OFF -DFEATURE_concurrent=OFF -DFEATURE_androiddeployqt=OFF \
 	-DFEATURE_sql=OFF \
@@ -143,7 +133,7 @@ endif
 
 .qt: qt toolchain.cmake
 	$(CMAKECLEAN)
-	$(QTBASE_HOSTVARS) $(CMAKE) $(QTBASE_CONFIG)
+	$(CMAKE) $(QTBASE_CONFIG)
 	+PATH="$(PATH):$(PREFIX)/bin" $(CMAKEBUILD)
 	$(CMAKEINSTALL)
 	touch $@



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/094833f733383cfde7235989c4da777d2817d98a

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/094833f733383cfde7235989c4da777d2817d98a
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help