[vlc-commits] [Git][videolan/vlc][3.0.x] demux: adaptive: fix macOS target version check

Steve Lhomme (@robUx4) gitlab at videolan.org
Tue Mar 10 14:13:30 UTC 2026



Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
342e67cc by Marvin Scholz at 2026-03-10T13:55:31+00:00
demux: adaptive: fix macOS target version check

The needed header here is Availability.h and TARGET_OS_OSX is a more
correct way to check for macOS here.

In practice this did not cause problems as __MAC_OS_X_VERSION_MIN_REQUIRED
ended up not defined so treated as 0, making the check true regardless
of the actual targeted version.

- - - - -


1 changed file:

- modules/demux/adaptive/tools/Compatibility.hpp


Changes:

=====================================
modules/demux/adaptive/tools/Compatibility.hpp
=====================================
@@ -24,9 +24,9 @@
    incomplete/bogus c++17 with MacOS <= 10.13 and iOS < 12 */
 
 #ifdef __APPLE__
-# include <TargetConditionals.h>
+# include <Availability.h>
 # if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < 120000) || \
-     (TARGET_OS_MAC && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400)
+     (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400)
 #  define IOS_INCOMPLETE_CPP17
 # endif
 #endif



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/342e67cc65c56c6f2e8eec1a17636ef9dbbb53a1

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/342e67cc65c56c6f2e8eec1a17636ef9dbbb53a1
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list