[vlc-commits] [Git][videolan/vlc][master] udisk: fix crash while freeing uninitialized object

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
01e4f45f by Pierre Lamot at 2026-03-13T13:55:54+00:00
udisk: fix crash while freeing uninitialized object

sd_bus_open_system failing was jumping over the variable initialization

- - - - -


1 changed file:

- modules/services_discovery/udisks.c


Changes:

=====================================
modules/services_discovery/udisks.c
=====================================
@@ -474,13 +474,13 @@ static int Open(vlc_object_t *p_obj)
 
     int r;
 
+    sd_bus_error err = SD_BUS_ERROR_NULL;
     /* connect to the session bus */
     r =  sd_bus_open_system(&p_sys->bus);
     if(r < 0)
         goto error;
    sd_bus *bus = p_sys->bus;
    sd_bus_message *reply = NULL;
-   sd_bus_error err = SD_BUS_ERROR_NULL;
    r = sd_bus_call_method(bus, DBUS_INTERFACE_UDISKS2, DBUS_PATH_UDISKS2_MANAGER,
                           DBUS_INTERFACE_UDISKS2_MANAGER, "GetBlockDevices",
                           &err, &reply, "a{sv}", NULL);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/01e4f45f829283917b5630010019a62c63fbbd2f

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/01e4f45f829283917b5630010019a62c63fbbd2f
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance