[vlc-commits] [Git][videolan/vlc][3.0.x] 3 commits: qt: remove unused lambda captures

[Steve Lhomme (@robUx4)]

Hello everyone

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
2706fc94 by Steve Lhomme at 2026-03-18T13:21:29+00:00
qt: remove unused lambda captures

Consecutive to 6da8ba684714ee535dc9ae2c67ca3f9d57eadb90.

- - - - -
cfb7b27f by Steve Lhomme at 2026-03-18T13:21:29+00:00
qt: remove unused variable

ExtensionsManager::getInstance( p_intf ) is already called earlier.
Leftover from 96df5fd9570b13e9be72f0836bc69ae47a39038e.

- - - - -
e339d837 by Steve Lhomme at 2026-03-18T13:21:29+00:00
qt: use the regular QAbstractItemView::dataChanged signature

This fixes a warning.

- - - - -


8 changed files:

- modules/gui/qt/components/interface_widgets.cpp
- modules/gui/qt/components/playlist/selector.cpp
- modules/gui/qt/components/playlist/views.cpp
- modules/gui/qt/components/playlist/views.hpp
- modules/gui/qt/dialogs/plugins.cpp
- modules/gui/qt/main_interface.cpp
- modules/gui/qt/util/customwidgets.cpp
- modules/gui/qt/util/searchlineedit.cpp


Changes:

=====================================
modules/gui/qt/components/interface_widgets.cpp
=====================================
@@ -973,7 +973,7 @@ TimeLabel::TimeLabel( intf_thread_t *_p_intf, TimeLabel::Display _displayType  )
 
 //same as Qt::AA_UseStyleSheetPropagationInWidgetStyles
 #if !HAS_QT57
-    connect(qApp, &QApplication::paletteChanged, this, [this, updateStyle](){
+    connect(qApp, &QApplication::paletteChanged, this, [updateStyle](){
         updateStyle();
     });
 #endif


=====================================
modules/gui/qt/components/playlist/selector.cpp
=====================================
@@ -433,7 +433,7 @@ PLSelItem * PLSelector::addItem (
       updateStyle();
 //same as Qt::AA_UseStyleSheetPropagationInWidgetStyles
 #if !HAS_QT57
-      connect(qApp, &QApplication::paletteChanged, selItem, [selItem, updateStyle](){
+      connect(qApp, &QApplication::paletteChanged, selItem, [updateStyle](){
           updateStyle();
       });
 #endif


=====================================
modules/gui/qt/components/playlist/views.cpp
=====================================
@@ -555,7 +555,7 @@ void PicFlowView::setSelection(const QRect &, QFlags<QItemSelectionModel::Select
     // No selection possible
 }
 
-void PicFlowView::dataChanged( const QModelIndex &topLeft, const QModelIndex &bottomRight )
+void PicFlowView::dataChanged( const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> & )
 {
     int currentIndex = picFlow->centerIndex();
     for(int i = topLeft.row(); i<=bottomRight.row(); i++ )


=====================================
modules/gui/qt/components/playlist/views.hpp
=====================================
@@ -144,7 +144,7 @@ private:
     PictureFlow *picFlow;
 
 public slots:
-    void dataChanged( const QModelIndex &, const QModelIndex &);
+    void dataChanged( const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> &roles = QVector<int>()) override;
 private slots:
     void playItem( int );
 };


=====================================
modules/gui/qt/dialogs/plugins.cpp
=====================================
@@ -261,7 +261,6 @@ ExtensionTab::ExtensionTab( intf_thread_t *p_intf_ )
     buttonsBox->addButton( butMoreInfo, QDialogButtonBox::ActionRole );
 
     // Reload button
-    ExtensionsManager *EM = ExtensionsManager::getInstance( p_intf );
     QPushButton *reload = new QPushButton( QIcon( ":/update.svg" ),
                                            qtr( "Reload extensions" ),
                                            this );


=====================================
modules/gui/qt/main_interface.cpp
=====================================
@@ -581,7 +581,7 @@ inline void MainInterface::createStatusBar()
     updateStyle();
 //same as Qt::AA_UseStyleSheetPropagationInWidgetStyles
 #if !HAS_QT57
-    connect(qApp, &QApplication::paletteChanged, this, [this, updateStyle](){
+    connect(qApp, &QApplication::paletteChanged, this, [updateStyle](){
         updateStyle();
     });
 #endif


=====================================
modules/gui/qt/util/customwidgets.cpp
=====================================
@@ -432,7 +432,7 @@ YesNoCheckBox::YesNoCheckBox( QWidget *parent ) : QCheckBox( parent )
     updateStyle();
 //same as Qt::AA_UseStyleSheetPropagationInWidgetStyles
 #if !HAS_QT57
-    connect(qApp, &QApplication::paletteChanged, this, [this, updateStyle](){
+    connect(qApp, &QApplication::paletteChanged, this, [updateStyle](){
         updateStyle();
     });
 #endif


=====================================
modules/gui/qt/util/searchlineedit.cpp
=====================================
@@ -66,7 +66,7 @@ SearchLineEdit::SearchLineEdit( QWidget *parent ) : QLineEdit( parent )
     updateStyle();
 //same as Qt::AA_UseStyleSheetPropagationInWidgetStyles
 #if !HAS_QT57
-    connect(qApp, &QApplication::paletteChanged, this, [this, updateStyle](){
+    connect(qApp, &QApplication::paletteChanged, this, [updateStyle](){
         updateStyle();
     });
 #endif



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/04b62205bcadd7d1ebb126d278d9e6cafebe917f...e339d8376f4e459b99d18222a150224a1baf26fe

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/04b62205bcadd7d1ebb126d278d9e6cafebe917f...e339d8376f4e459b99d18222a150224a1baf26fe
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance