[vlc-commits] [Git][videolan/vlc][master] lib: fix race in libvlc_media_list_player_get_media_player()

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
aaed04d2 by Martin Finkel at 2026-03-20T06:41:38+00:00
lib: fix race in libvlc_media_list_player_get_media_player()

Hold the lock while reading and retaining p_mi, like other getters do.

- - - - -


1 changed file:

- lib/media_list_player.c


Changes:

=====================================
lib/media_list_player.c
=====================================
@@ -592,8 +592,11 @@ void libvlc_media_list_player_set_media_player(libvlc_media_list_player_t * p_ml
  **************************************************************************/
 libvlc_media_player_t * libvlc_media_list_player_get_media_player(libvlc_media_list_player_t * p_mlp)
 {
-    libvlc_media_player_retain(p_mlp->p_mi);
-    return p_mlp->p_mi;
+    lock(p_mlp);
+    libvlc_media_player_t *p_mi = p_mlp->p_mi;
+    libvlc_media_player_retain(p_mi);
+    unlock(p_mlp);
+    return p_mi;
 }
 
 /**************************************************************************



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/aaed04d2675a9f76c8a5bc3b734378a028b9f2ba

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/aaed04d2675a9f76c8a5bc3b734378a028b9f2ba
You're receiving this email because of your account on code.videolan.org.