[vlc-commits] [Git][videolan/vlc][master] opengl: silence OpenGL deprecation warnings on darwin

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
1e2250a3 by Alexandre Janniaux at 2026-03-27T05:46:20+01:00
opengl: silence OpenGL deprecation warnings on darwin

OpenGL has been deprecated for a while on macOS 10.14+, iOS 12+, and
tvOS 12+, which produces many -Wdeprecated-declarations warnings during
the build. CI filters also generate warnings because of that.

Apple provides GL_SILENCE_DEPRECATION and CI_SILENCE_GL_DEPRECATION
defines to suppress these expected warnings. Since we do dynamic loading
of OpenGL anyway, and potentially dynamic loading of the OpenGL
framework itself, we can remove the warning.

- - - - -


7 changed files:

- modules/video_filter/Makefile.am
- modules/video_filter/meson.build
- modules/video_output/Makefile.am
- modules/video_output/apple/meson.build
- modules/video_output/opengl/meson.build
- modules/visualization/Makefile.am
- modules/visualization/meson.build


Changes:

=====================================
modules/video_filter/Makefile.am
=====================================
@@ -117,6 +117,7 @@ video_filter_LTLIBRARIES = \
 
 # macOS / iOS hardware video filters
 libci_filters_plugin_la_SOURCES = video_filter/ci_filters.m codec/vt_utils.c codec/vt_utils.h
+libci_filters_plugin_la_OBJCFLAGS = $(AM_OBJCFLAGS) -DGL_SILENCE_DEPRECATION -DCI_SILENCE_GL_DEPRECATION
 libci_filters_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(video_filterdir)' \
 	-Wl,-framework,Foundation -Wl,-framework,CoreGraphics -Wl,-framework,CoreImage \
 	-Wl,-framework,CoreVideo


=====================================
modules/video_filter/meson.build
=====================================
@@ -341,6 +341,7 @@ vlc_modules += {
         frameworks['CoreVideo'],
         (have_osx) ? dependency('gl', required: true) : frameworks['OpenGLES'],
     ],
+    'objc_args' : ['-DGL_SILENCE_DEPRECATION', '-DCI_SILENCE_GL_DEPRECATION'],
     'include_directories' : [include_directories('../codec')],
     'enabled' : host_system == 'darwin',
 }


=====================================
modules/video_output/Makefile.am
=====================================
@@ -114,6 +114,7 @@ libuiview_window_plugin_la_OBJCFLAGS = $(AM_OBJCFLAGS) -fobjc-arc
 libcaeagl_ios_plugin_la_SOURCES = video_output/apple/VLCOpenGLES2VideoView.m
 libcaeagl_ios_plugin_la_LDFLAGS = $(AM_LDFLAGS) \
 	-Wl,-framework,Foundation,-framework,OpenGLES,-framework,QuartzCore,-framework,UIKit
+libcaeagl_ios_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) -DGL_SILENCE_DEPRECATION
 libcaeagl_ios_plugin_la_OBJCFLAGS = $(AM_OBJCFLAGS) -fobjc-arc
 
 libcvpx_gl_plugin_la_SOURCES = video_output/apple/VLCCVOpenGLProvider.m


=====================================
modules/video_output/apple/meson.build
=====================================
@@ -16,7 +16,7 @@ vlc_modules += {
         'VLCCVOpenGLProvider.m',
         '../../codec/vt_utils.c'
     ),
-    'objc_args' : ['-fobjc-arc'],
+    'objc_args' : ['-fobjc-arc', '-DGL_SILENCE_DEPRECATION'],
     'dependencies' : [
         frameworks['Foundation'],
         frameworks['CoreFoundation'],
@@ -56,7 +56,7 @@ if have_ios or have_tvos
     vlc_modules += {
         'name' : 'caeagl',
         'sources' : files('VLCOpenGLES2VideoView.m'),
-        'objc_args' : ['-fobjc-arc'],
+        'objc_args' : ['-fobjc-arc', '-DGL_SILENCE_DEPRECATION'],
         'dependencies' : [
             frameworks['Foundation'],
             frameworks['UIKit'],


=====================================
modules/video_output/opengl/meson.build
=====================================
@@ -2,6 +2,9 @@ opengl_headers_c_args = []
 if host_system == 'android'
     opengl_headers_c_args += ['-DUSE_OPENGL_ES2']
 endif
+if host_system == 'darwin'
+    opengl_headers_c_args += ['-DGL_SILENCE_DEPRECATION']
+endif
 
 gl_common_dep = declare_dependency(
     sources: files(


=====================================
modules/visualization/Makefile.am
=====================================
@@ -7,6 +7,10 @@ libglspectrum_plugin_la_SOURCES = \
 	visualization/visual/window.c visualization/visual/window.h \
 	visualization/visual/window_presets.h
 libglspectrum_plugin_la_LIBADD = $(GL_LIBS) $(LIBM)
+libglspectrum_plugin_la_CPPFLAGS = $(AM_CPPFLAGS)
+if HAVE_OSX
+libglspectrum_plugin_la_CPPFLAGS += -DGL_SILENCE_DEPRECATION
+endif
 if HAVE_GL
 visu_LTLIBRARIES += libglspectrum_plugin.la
 endif


=====================================
modules/visualization/meson.build
=====================================
@@ -6,7 +6,7 @@ vlc_modules += {
       'visual/window.c', 'visual/window.h',
       'visual/window_presets.h'),
     'dependencies' : [opengl_dep, m_lib],
-    'c_args' : [ contrib_inc_args ],
+    'c_args' : [ contrib_inc_args ] + (host_system == 'darwin' ? ['-DGL_SILENCE_DEPRECATION'] : []),
     'enabled' : opengl_dep.found(),
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1e2250a3150a98c3547e26ca03411f26d4d3fc19

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1e2250a3150a98c3547e26ca03411f26d4d3fc19
You're receiving this email because of your account on code.videolan.org.