[vlc-commits] [Git][videolan/vlc][master] qml: do not adjust the source with old Qt in `PartialEffect`

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
7e42bfc0 by Fatih Uzunoglu at 2026-03-28T20:52:24+01:00
qml: do not adjust the source with old Qt in `PartialEffect`

Switching source seems to be breaking the interface with old Qt,
this is most likely a Qt bug.

Regression since 2630a5cd.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/PartialEffect.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/PartialEffect.qml
=====================================
@@ -71,7 +71,10 @@ Item {
 
         blending: false
 
-        readonly property Item source: useSubTexture ? sourceVisualTextureProviderIndirection : root.source
+        // WARNING: Switching the source should be fine, but old Qt (Qt 6.2.13) seems to break the interface
+        //          in this case. The indirection does not use sub-rect if it is not relevant, so in this
+        //          case it would act as a dummy indirection to prevent the Qt bug.
+        readonly property Item source: ((MainCtx.qtVersion() < MainCtx.qtVersionCheck(6, 4, 2)) || useSubTexture) ? sourceVisualTextureProviderIndirection : root.source
 
         readonly property rect discardRect: {
             if (blending && !useSubTexture)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7e42bfc0328d93b6f1a7b67d16f43e5fd7c1f9cb

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7e42bfc0328d93b6f1a7b67d16f43e5fd7c1f9cb
You're receiving this email because of your account on code.videolan.org.