[vlc-commits] [Git][videolan/vlc][master] qml: clear input items when dragging finishes in `DragItem`

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
43cf1d2a by Fatih Uzunoglu at 2026-05-11T10:01:11+02:00
qml: clear input items when dragging finishes in `DragItem`

Keeping the input items around until the next drag
is not enough, because it makes the input items to
stay around unnecessarily, and potentially forever.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/DragItem.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/DragItem.qml
=====================================
@@ -90,9 +90,11 @@ Item {
     }
 
     /**
+      * This function must be called when dragging is active.
       * @return {Promise} Promise object of the input items
       */
     function getSelectedInputItem() {
+        console.assert(dragItem.Drag.active)
         if (_inputItems)
             return Promise.resolve(dragItem._inputItems)
         else if (dragItem._dropPromise)
@@ -304,6 +306,7 @@ Item {
 
                 _covers = []
                 _data = []
+                dragItem._inputItems = undefined
             }
 
             transitions: ({



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/43cf1d2a54999f2a74435c4d2e31b5268cd03d0f

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/43cf1d2a54999f2a74435c4d2e31b5268cd03d0f
You're receiving this email because of your account on code.videolan.org.