[vlc-commits] [Git][videolan/vlc][master] macosx: Fix type mismatch warnings for media items in...

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
5a0b3159 by Claudio Cambra at 2026-05-11T22:28:01+02:00
macosx: Fix type mismatch warnings for media items in VLCLibraryCollectionViewMediaItemSupplementaryDetailView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCLibraryCollectionViewMediaItemSupplementaryDetailView.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewMediaItemSupplementaryDetailView.m
=====================================
@@ -67,7 +67,7 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewMediaItem
         return @"";
     }
 
-    const VLCMediaLibraryMediaItem * const actualItem = self.representedItem.item;
+    VLCMediaLibraryMediaItem * const actualItem = self.representedItem.item.firstMediaItem;
     NSMutableArray<NSString *> * const strings = NSMutableArray.array;
 
     if (actualItem.year > 0) {
@@ -104,7 +104,7 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewMediaItem
 - (void)updateRepresentation
 {
     NSAssert(self.representedItem, @"no represented item assigned for collection view item", nil);
-    VLCMediaLibraryMediaItem * const actualItem = self.representedItem.item;
+    VLCMediaLibraryMediaItem * const actualItem = self.representedItem.item.firstMediaItem;
     NSAssert(actualItem != nil, @"represented item is not a media item", nil);
 
     _mediaItemTitleTextField.stringValue = actualItem.displayString;
@@ -210,7 +210,7 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewMediaItem
 
 - (IBAction)primaryDetailAction:(id)sender
 {
-    VLCMediaLibraryMediaItem * const actualItem = self.representedItem.item;
+    const id<VLCMediaLibraryItemProtocol> actualItem = self.representedItem.item;
     if (actualItem == nil || !actualItem.primaryActionableDetail) {
         return;
     }
@@ -222,7 +222,7 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewMediaItem
 
 - (IBAction)secondaryDetailAction:(id)sender
 {
-    VLCMediaLibraryMediaItem * const actualItem = self.representedItem.item;
+    const id<VLCMediaLibraryItemProtocol> actualItem = self.representedItem.item;
     if (actualItem == nil || !actualItem.secondaryActionableDetail) {
         return;
     }
@@ -234,7 +234,7 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewMediaItem
 
 - (IBAction)favoriteAction:(id)sender
 {
-    VLCMediaLibraryMediaItem * const mediaItem = self.representedItem.item;
+    const id<VLCMediaLibraryItemProtocol> mediaItem = self.representedItem.item;
     if ([mediaItem toggleFavorite] == VLC_SUCCESS) {
         VLCMediaLibraryMediaItem * const updatedItem =
             [VLCMediaLibraryMediaItem mediaItemForLibraryID:mediaItem.libraryID];



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/5a0b3159d25c7f58d46ac0cfc30ffffd29313d31

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/5a0b3159d25c7f58d46ac0cfc30ffffd29313d31
You're receiving this email because of your account on code.videolan.org.