[vlc-commits] [Git][videolan/vlc][master] macosx: don't close library window when user navigated back during playback

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
3041a0c3 by Serhii Bykov at 2026-05-13T10:39:13+00:00
macosx: don't close library window when user navigated back during playback

- - - - -


1 changed file:

- modules/gui/macosx/windows/video/VLCVideoOutputProvider.m


Changes:

=====================================
modules/gui/macosx/windows/video/VLCVideoOutputProvider.m
=====================================
@@ -555,9 +555,14 @@ static int WindowFloatOnTop(vlc_object_t *obj,
         [videoWindow toggleFullScreen:self];
     }
 
-    if (videoWindow.class == VLCLibraryWindow.class
-        && ((VLCLibraryWindow *)videoWindow).embeddedVideoPlaybackActive) {
-        [(VLCLibraryWindow *)videoWindow disableVideoPlaybackAppearance];
+    if (videoWindow.class == VLCLibraryWindow.class) {
+        // If `embeddedVideoPlaybackActive` is already `NO`, the user navigated back
+        // while playback was ongoing - `disableVideoPlaybackAppearance` was already
+        // called at that point, so nothing more to do here.
+        
+        if (((VLCLibraryWindow *)videoWindow).embeddedVideoPlaybackActive) {
+            [(VLCLibraryWindow *)videoWindow disableVideoPlaybackAppearance];
+        }
     } else {
         [videoWindow close];
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3041a0c39240fbf4c0502e9c615d2273be46dde6

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3041a0c39240fbf4c0502e9c615d2273be46dde6
You're receiving this email because of your account on code.videolan.org.