[vlc-commits] [Git][videolan/vlc][master] lua/VLSub: fix Close button not properly deactivating extension

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
bf8c5c42 by Lucas Dima at 2026-05-18T16:08:14+02:00
lua/VLSub: fix Close button not properly deactivating extension

The Close button in VLSub's main interface called deactivate() directly,
which hides the dialog but does not notify VLC that the extension is
inactive. This desynchronizes VLC's internal toggle state, causing the
menu item to require two clicks to reopen VLSub after closing it.

Fix by calling close() instead, which calls vlc.deactivate() and
properly notifies VLC of the state change.

- - - - -


1 changed file:

- share/lua/extensions/VLSub.lua


Changes:

=====================================
share/lua/extensions/VLSub.lua
=====================================
@@ -446,7 +446,7 @@ function interface_main()
   dlg:add_button(
     lang["int_dowload_sel"], download_subtitles, 3, 7, 1, 1)
   dlg:add_button(
-    lang["int_close"], deactivate, 4, 7, 1, 1)
+    lang["int_close"], close, 4, 7, 1, 1)
 
   assoc_select_conf(
     'language',



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/bf8c5c423ea5f9f5bb7506549f4e035a1d328caf

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/bf8c5c423ea5f9f5bb7506549f4e035a1d328caf
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help