[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: fix miniplayer visibility twitching when player is stopped

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
add2f67e by Fatih Uzunoglu at 2026-05-29T13:48:28+02:00
qml: fix miniplayer visibility twitching when player is stopped

It seems that the binding for `visible` is either evaluated
before `animation.running` becomes `true`, or for some reason
the animation actually starts later.

As we do in other places (like `visible: height > 0`, combined
with `Behavior`), we can do the same here.

- - - - -
eebbefe4 by Fatih Uzunoglu at 2026-05-29T13:48:28+02:00
qml: respect `height` for anchor margin in `MiniPlayer`

So that if `height` is explicitly set to something else,
we use that for anchoring.

- - - - -


1 changed file:

- modules/gui/qt/player/qml/MiniPlayer.qml


Changes:

=====================================
modules/gui/qt/player/qml/MiniPlayer.qml
=====================================
@@ -26,9 +26,11 @@ import VLC.Style
 ControlBar {
     id: root
 
-    visible: animation.running || (state === "inViewport")
+    visible: (-anchors.bottomMargin < height) || (state === "inViewport")
 
-    anchors.bottomMargin: (state === "outViewport") ? -_delayedImplicitHeight : 0
+    anchors.bottomMargin: (state === "outViewport") ? -height : 0
+
+    height: _delayedImplicitHeight
 
     state: Player.isStarted ? "inViewport"
                             : "outViewport"



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/1f78f3778c2b0b646ac521c07a0d84e64cd19595...eebbefe46a0655be4bed2e9d6d50d1ce48d400b8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/1f78f3778c2b0b646ac521c07a0d84e64cd19595...eebbefe46a0655be4bed2e9d6d50d1ce48d400b8
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help