[vlc-commits] [Git][videolan/vlc][master] lib: media_player: remove the pts argument of libvlc_audio_flush_cb

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
a8b776a1 by Martin Finkel at 2026-10-10T01:34:36+00:00
lib: media_player: remove the pts argument of libvlc_audio_flush_cb

The amem audio output has always called the flush callback with the
opaque pointer only, since the callback was added in 4cc939684b. The pts
argument was therefore never set, and calling the user callback through
a function pointer of a different type is undefined behavior.

The core audio output flush does not carry any timestamp, so there is
no meaningful value to pass. Remove the argument, which also makes the
callback consistent with libvlc_audio_drain_cb.

- - - - -


1 changed file:

- include/vlc/libvlc_media_player.h


Changes:

=====================================
include/vlc/libvlc_media_player.h
=====================================
@@ -1653,7 +1653,7 @@ typedef void (*libvlc_audio_resume_cb)(void *data, int64_t pts);
  *
  * \param[in] data data pointer as passed to libvlc_audio_set_callbacks()
  */
-typedef void (*libvlc_audio_flush_cb)(void *data, int64_t pts);
+typedef void (*libvlc_audio_flush_cb)(void *data);
 
 /**
  * Callback prototype for audio buffer drain.



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/a8b776a10757ac6f7136278177592fc20ba381bb

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/a8b776a10757ac6f7136278177592fc20ba381bb
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help