[vlc-commits] [Git][videolan/vlc][master] 3 commits: qml: remove video list labels
Jean-Baptiste Kempf (@jbk)
gitlab at videolan.org
Mon Oct 12 22:04:05 UTC 2026
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
9f7b5f2c by Leon Vitanos at 2026-10-12T23:48:13+02:00
qml: remove video list labels
- - - - -
6ba413cf by Leon Vitanos at 2026-10-12T23:48:13+02:00
qml: remove playlist list labels
- - - - -
392bc1d0 by Leon Vitanos at 2026-10-12T23:48:13+02:00
qml: remove unused cover labels from TableColumns
- - - - -
6 changed files:
- modules/gui/qt/medialibrary/qml/PlaylistMedia.qml
- modules/gui/qt/medialibrary/qml/PlaylistMediaList.qml
- modules/gui/qt/medialibrary/qml/VideoAll.qml
- modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
- modules/gui/qt/medialibrary/qml/VideoListDisplay.qml
- modules/gui/qt/widgets/qml/TableColumns.qml
Changes:
=====================================
modules/gui/qt/medialibrary/qml/PlaylistMedia.qml
=====================================
@@ -189,16 +189,6 @@ Widgets.TableViewExt {
showCriterias: (root.sortModel === root._modelSmall)
criteriaCover: "thumbnail"
-
- //-----------------------------------------------------------------------------------------
- // TableColumns implementation
-
- function titlecoverLabels(model) {
- return [
- (model) ? model.resolution_name : "",
- (model) ? model.channel : ""
- ].filter(function(a) { return a !== "" })
- }
}
Rectangle {
=====================================
modules/gui/qt/medialibrary/qml/PlaylistMediaList.qml
=====================================
@@ -516,13 +516,6 @@ MainViewLoader {
titleCover_radius: (isMusic) ? VLCStyle.trackListAlbumCover_radius
: VLCStyle.listAlbumCover_radius
-
- //---------------------------------------------------------------------------------
-
- // NOTE: This makes sure we display the playlist count on the item.
- function titlecoverLabels(model) {
- return [];
- }
}
}
}
=====================================
modules/gui/qt/medialibrary/qml/VideoAll.qml
=====================================
@@ -66,7 +66,6 @@ MainViewLoader {
// function(model) -> [strings....]
// used to get grid labels per model item
property var gridLabels: getLabel
- property var listLabels: getLabel
property bool showGroupCountColumn: false
@@ -236,8 +235,6 @@ MainViewLoader {
root.contextMenu.popup(selectionModel.selectedIndexes, globalMousePos)
}
- coverLabels: root.listLabels
-
showGroupCountColumn: root.showGroupCountColumn
coverWidth: root.listCoverWidth
=====================================
modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
=====================================
@@ -83,8 +83,6 @@ Widgets.PageExt {
gridLabels: _meta?.gridLabels ?? videoAll.getLabel
- listLabels: _meta?.listLabels ?? videoAll.getLabel
-
showGroupCountColumn: _meta?.showGroupCountColumn ?? false
sectionProperty: _meta?.sectionProperty ?? ""
@@ -138,8 +136,6 @@ Widgets.PageExt {
property var gridLabels: videoAll.getLabel
- property var listLabels: videoAll.getLabel
-
property string sectionProperty: {
switch (model.sortCriteria) {
case "title":
@@ -189,10 +185,6 @@ Widgets.PageExt {
return videoAll.getLabelGroup(model, qsTr("%1 Videos"))
}
- property var listLabels: function (model) {
- return videoAll.getLabel(model)
- }
-
property bool showGroupCountColumn: true
function onAction(indexes) {
@@ -252,10 +244,6 @@ Widgets.PageExt {
return videoAll.getLabelGroup(model, qsTr("%1 Videos"))
}
- property var listLabels: function (model) {
- return videoAll.getLabel(model)
- }
-
property bool showGroupCountColumn: true
function onAction(indexes) {
=====================================
modules/gui/qt/medialibrary/qml/VideoListDisplay.qml
=====================================
@@ -35,8 +35,6 @@ Widgets.TableViewExt {
// NOTE: This is useful for groups because our main criteria is 'name' instead of 'title'.
property string mainCriteria: "title"
- property var coverLabels
-
property bool showGroupCountColumn: false
property real coverHeight: VLCStyle.listAlbumCover_height
@@ -137,7 +135,5 @@ Widgets.TableViewExt {
titleCover_height: listView_id.coverHeight
titleCover_width: listView_id.coverWidth
titleCover_radius: listView_id.coverRadius
-
- titlecoverLabels: listView_id.coverLabels
}
}
=====================================
modules/gui/qt/widgets/qml/TableColumns.qml
=====================================
@@ -40,12 +40,6 @@ Item {
property int titleCover_height: VLCStyle.trackListAlbumCover_heigth
property int titleCover_radius: VLCStyle.trackListAlbumCover_radius
- // function (model) -> [string...]
- // implement this function to show labels in title Cover
- property var titlecoverLabels: function(model) {
- return []
- }
-
// function (rowModel, colModel) -> string
// implement this function for providing custom text for title column
property var _titleTextProvider: function (rowModel, colModel) {
@@ -130,23 +124,6 @@ Item {
}
}
- imageOverlay: Item {
- width: cover.width
- height: cover.height
-
- Widgets.VideoQualityLabels {
- anchors {
- top: parent.top
- right: parent.right
- topMargin: VLCStyle.margin_xxsmall
- leftMargin: VLCStyle.margin_xxsmall
- rightMargin: VLCStyle.margin_xxsmall
- }
-
- labels: root.titlecoverLabels(titleDel.rowModel)
- }
- }
-
DefaultShadow {
}
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a5538c557d276378d5ba0f8f8010a8b87eaa6f78...392bc1d0abdb7396b6c97fef206efa1d23868e19
--
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a5538c557d276378d5ba0f8f8010a8b87eaa6f78...392bc1d0abdb7396b6c97fef206efa1d23868e19
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help
More information about the vlc-commits
mailing list