[vlc-commits] [Git][videolan/vlc][master] demux: avi: fix cleanup crash due to jump over init

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
c116df96 by François Cartegnie at 2026-10-22T07:00:23+02:00
demux: avi: fix cleanup crash due to jump over init

The regression by 08e0999642c6435ce39a94d56969e3b4814801ee
removed a check that was in fact concealing the existing issue.

fixes #30125

- - - - -


1 changed file:

- modules/demux/avi/avi.c


Changes:

=====================================
modules/demux/avi/avi.c
=====================================
@@ -3071,14 +3071,15 @@ static void AVI_ExtractSubtitle( demux_t *p_demux,
     char *psz_description = NULL;
     avi_chunk_indx_t *p_indx = NULL;
 
-    if( !p_sys->b_seekable )
-        goto exit;
-
-    p_indx = AVI_ChunkFind( p_strl, AVIFOURCC_indx, 0, false );
     avi_chunk_t ck;
     AVI_ChunkInit( &ck, p_strl->i_depth + 1 );
     int64_t  i_position;
     unsigned i_size;
+
+    if( !p_sys->b_seekable )
+        goto exit;
+
+    p_indx = AVI_ChunkFind( p_strl, AVIFOURCC_indx, 0, false );
     if( p_indx )
     {
         if( p_indx->i_indextype == AVI_INDEX_OF_INDEXES &&



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/c116df96ee86c58aff6da31593f1c2dc57ab3a1e

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/c116df96ee86c58aff6da31593f1c2dc57ab3a1e
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help