[vlc-commits] [Git][videolan/vlc][master] 4 commits: macosx: Mark unused returnCode completion handler parameter in runModalForWindow

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
d5566591 by Claudio Cambra at 2026-09-08T00:53:34+00:00
macosx: Mark unused returnCode completion handler parameter in runModalForWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a52311cc by Claudio Cambra at 2026-09-08T00:53:34+00:00
macosx: Fix number comparison compile warnings in VLCTimeSelectionPanelController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
859369a7 by Claudio Cambra at 2026-09-08T00:53:34+00:00
macosx: Remove trailing semicolon from adError in VLCErrorWindowController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6d3d1008 by Claudio Cambra at 2026-09-08T00:53:34+00:00
macosx: Mark rendererMenuItem as nonatomic (non-synthesized setter)

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


3 changed files:

- modules/gui/macosx/menus/renderers/VLCRendererMenuController.h
- modules/gui/macosx/panels/VLCTimeSelectionPanelController.m
- modules/gui/macosx/windows/VLCErrorWindowController.m


Changes:

=====================================
modules/gui/macosx/menus/renderers/VLCRendererMenuController.h
=====================================
@@ -28,7 +28,7 @@
 @interface VLCRendererMenuController : NSObject <VLCRendererDiscoveryDelegate>
 
 @property (readwrite, weak) NSMenu *rendererMenu;
- at property (readwrite, weak) NSMenuItem *rendererMenuItem;
+ at property (readwrite, nonatomic, weak) NSMenuItem *rendererMenuItem;
 @property (readwrite, weak) NSMenuItem *rendererNoneItem;
 @property (readonly, strong) NSArray<VLCRendererItem *> *rendererItems;
 


=====================================
modules/gui/macosx/panels/VLCTimeSelectionPanelController.m
=====================================
@@ -114,7 +114,7 @@
     _completionHandler = handler;
 
     [window beginSheet:self.window
-        completionHandler:^(NSModalResponse returnCode) {
+        completionHandler:^(NSModalResponse __unused returnCode) {
             if (self->_keyMonitor) {
                 [NSEvent removeMonitor:self->_keyMonitor];
             }
@@ -214,11 +214,11 @@
         return;
     }
 
-    NSInteger count = MIN(parts.count, 3 - startingField);
+    const NSUInteger count = MIN(parts.count, (NSUInteger)(3 - startingField));
 
     NSInteger newPosition = 0;
     NSInteger timeDifference = currentFieldSecs;
-    for (NSInteger i = 0; i < count; i++) {
+    for (NSUInteger i = 0; i < count; i++) {
         NSString *part = [parts[i]
             stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
         newPosition += timeDifference * part.integerValue;


=====================================
modules/gui/macosx/windows/VLCErrorWindowController.m
=====================================
@@ -57,7 +57,7 @@
     }
 }
 
-- (void)addError:(NSString *)title withMsg:(NSString *)message;
+- (void)addError:(NSString *)title withMsg:(NSString *)message
 {
     /* format our string as desired */
     NSMutableAttributedString * ourError;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/aababdeb4b4d4ffb6f5f405832d40dac64d8ac71...6d3d1008d5f646adddda6b5dc0c210e45a645959

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/aababdeb4b4d4ffb6f5f405832d40dac64d8ac71...6d3d1008d5f646adddda6b5dc0c210e45a645959
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help