[vlc-commits] [Git][videolan/vlc][3.0.x] qt: comparing a QVariant to QVariant::Invalid is broken in qt6

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
ac6acee4 by Pierre Lamot at 2026-09-16T04:43:20+00:00
qt: comparing a QVariant to QVariant::Invalid is broken in qt6

Note that QVariant::Type is deprecated in Qt6
https://doc.qt.io/qt-6/qvariant-obsolete.html#Type-enum

fix: #30119

- - - - -


1 changed file:

- modules/gui/qt/components/open_panels.cpp


Changes:

=====================================
modules/gui/qt/components/open_panels.cpp
=====================================
@@ -545,7 +545,7 @@ void DiscOpenPanel::updateMRL()
     discPath = ui.deviceCombo->currentText();
 
     int tmp = ui.deviceCombo->findText( discPath );
-    if( tmp != -1 &&  ui.deviceCombo->itemData( tmp ) != QVariant::Invalid )
+    if( tmp != -1 &&  ui.deviceCombo->itemData( tmp ).isValid() )
         discPath = ui.deviceCombo->itemData( tmp ).toString();
 
     /* MRL scheme */



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ac6acee4778ece86433a7a2544b4273c121a5ee7

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ac6acee4778ece86433a7a2544b4273c121a5ee7
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help