[vlc-commits] [Git][videolan/vlc][master] wasapi: do not log GetMixFormat() on error

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
c6d9f176 by Steve Lhomme at 2026-09-16T08:18:46+00:00
wasapi: do not log GetMixFormat() on error

Bug introduced in 63b7a09e79e66133d64df4dfd9c3f970f75ce68d.

- - - - -


1 changed file:

- modules/audio_output/wasapi.c


Changes:

=====================================
modules/audio_output/wasapi.c
=====================================
@@ -822,9 +822,14 @@ static HRESULT Start(aout_stream_t *s, audio_sample_format_t *restrict pfmt,
 
             /* Render Ambisonics on the native mix format */
             hr = IAudioClient_GetMixFormat(sys->client, &pwf_mix);
-            if (FAILED(hr) || vlc_FromWave(pwf_mix, &fmt))
+            if (FAILED(hr))
             {
                 msg_Dbg(s, "failed to use mix format");
+                vlc_ToWave(pwfe, &fmt); /* failed, fallback to default */
+            }
+            else if (vlc_FromWave(pwf_mix, &fmt))
+            {
+                msg_Dbg(s, "unsupported mix format");
                 LogWaveFormat(vlc_object_logger(s), pwf_mix);
                 vlc_ToWave(pwfe, &fmt); /* failed, fallback to default */
             }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/c6d9f176cc411ec2dbe0e963765baebccf8ae424

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/c6d9f176cc411ec2dbe0e963765baebccf8ae424
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help