[vlc-commits] [Git][videolan/vlc][3.0.x] demux: mpc: fix sys based cleanup

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC


Commits:
968e0836 by François Cartegnie at 2026-09-16T13:27:41+02:00
demux: mpc: fix sys based cleanup

regression by 657ad5e3
fixes #30121

- - - - -


1 changed file:

- modules/demux/mpc.c


Changes:

=====================================
modules/demux/mpc.c
=====================================
@@ -145,6 +145,7 @@ static int Open( vlc_object_t * p_this )
     if( !p_sys )
         return VLC_ENOMEM;
 
+    p_demux->p_sys = p_sys;
     p_sys->i_position = 0;
 
     p_sys->reader.read = ReaderRead;
@@ -158,7 +159,10 @@ static int Open( vlc_object_t * p_this )
     /* Load info */
     mpc_streaminfo_init( &p_sys->info );
     if( mpc_streaminfo_read( &p_sys->info, &p_sys->reader ) != ERROR_CODE_OK )
-        goto error;
+    {
+        free( p_sys );
+        return VLC_EGENERIC;
+    }
 
     /* */
     mpc_decoder_setup( &p_sys->decoder, &p_sys->reader );
@@ -175,7 +179,6 @@ static int Open( vlc_object_t * p_this )
     /* Fill p_demux fields */
     p_demux->pf_demux = Demux;
     p_demux->pf_control = Control;
-    p_demux->p_sys = p_sys;
 
     /* */
 #ifndef MPC_FIXED_POINT



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/968e08366d2b089c87f787d5372f6831b1914a63

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/968e08366d2b089c87f787d5372f6831b1914a63
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help