[vlc-commits] [Git][videolan/vlc][3.0.x] demux: mkv: fix overflow check

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC


Commits:
f435eca1 by Steve Lhomme at 2026-09-17T05:17:09+02:00
demux: mkv: fix overflow check

It returns true when it overflows.

(cherry picked from commit 30430312611a37a4ee15694e83142071befab12b)
Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -


1 changed file:

- modules/demux/mkv/matroska_segment_parse.cpp


Changes:

=====================================
modules/demux/mkv/matroska_segment_parse.cpp
=====================================
@@ -508,7 +508,7 @@ void matroska_segment_c::ParseTrackEntry( const KaxTrackEntry *m )
             unsigned int i_display_height = vars.track_video_info.i_display_height;
 
             unsigned int h_crop;
-            if (!add_overflow(i_crop_left, i_crop_right, &h_crop))
+            if (add_overflow(i_crop_left, i_crop_right, &h_crop))
             {
                 debug( vars, "invalid horizontal crop %u+%u",
                               i_crop_left, i_crop_right );
@@ -523,7 +523,7 @@ void matroska_segment_c::ParseTrackEntry( const KaxTrackEntry *m )
             }
 
             unsigned int v_crop;
-            if (!add_overflow(i_crop_top, i_crop_bottom, &v_crop))
+            if (add_overflow(i_crop_top, i_crop_bottom, &v_crop))
             {
                 debug( vars, "invalid vertical crop %u+%u",
                               i_crop_top, i_crop_bottom);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/f435eca1e224616a236ba6186d575695d40cd2d7

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/f435eca1e224616a236ba6186d575695d40cd2d7
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help