[vlc-commits] [Git][videolan/vlc][master] macosx: Fix Reveal in Finder for browse items

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
cd37cf87 by Serhii Bykov at 2026-09-19T09:13:20+02:00
macosx: Fix Reveal in Finder for browse items

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCInputItem.m


Changes:

=====================================
modules/gui/macosx/library/VLCInputItem.m
=====================================
@@ -42,6 +42,8 @@ NSString * const VLCInputItemCommonDataDifferingFlagString = @"<differing>";
     input_item_parser_id_t *_p_parserID;
 }
 
+- (nullable NSURL *)localFileURL;
+
 - (void)parsingEnded:(int)status;
 - (void)subTreeAdded:(input_item_node_t *)p_node;
 
@@ -487,13 +489,23 @@ static const struct input_item_parser_cbs_t parserCallbacks =
     }];
 }
 
-- (void)moveToTrash
+- (nullable NSURL *)localFileURL
 {
     if (self.isStream) {
-        return;
+        return nil;
     }
 
-    NSURL * const pathUrl = [NSURL URLWithString:self.path];
+    NSString * const path = self.path;
+    if (path.length == 0) {
+        return nil;
+    }
+
+    return [NSURL fileURLWithPath:path];
+}
+
+- (void)moveToTrash
+{
+    NSURL * const pathUrl = self.localFileURL;
     if (pathUrl == nil) {
         return;
     }
@@ -508,11 +520,7 @@ static const struct input_item_parser_cbs_t parserCallbacks =
 
 - (void)revealInFinder
 {
-    if (self.isStream) {
-        return;
-    }
-
-    NSURL *pathUrl = [NSURL URLWithString:self.path];
+    NSURL * const pathUrl = self.localFileURL;
     if (pathUrl == nil) {
         return;
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cd37cf87249178970d07afa2671606a4979b1fda

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cd37cf87249178970d07afa2671606a4979b1fda
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help