[vlc-commits] [Git][videolan/vlc][master] macosx: Avoid double-invocation of barrier async

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
6d2e00f0 by Claudio Cambra at 2026-09-22T02:17:33+00:00
macosx: Avoid double-invocation of barrier async

Setters already use dispatch_barrier_async, no need to make use of this when assigning using dot notation which invokes the setters

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCLibraryModel.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryModel.m
=====================================
@@ -1162,7 +1162,6 @@ static void libraryCallback(void *p_data, const vlc_ml_event_t *p_event)
 
 - (void)dropCaches
 {
-    dispatch_barrier_async(_mediaItemCacheModificationQueue, ^{
         self.cachedVideoMedia = nil;
         self.cachedAudioMedia = nil;
         self.cachedRecentMedia = nil;
@@ -1170,27 +1169,11 @@ static void libraryCallback(void *p_data, const vlc_ml_event_t *p_event)
         self.cachedListOfShows = nil;
         self.cachedListOfMovies = nil;
         self.cachedListOfMonitoredFolders = nil;
-    });
-
-    dispatch_barrier_async(_albumCacheModificationQueue, ^{
         self.cachedAlbums = nil;
-    });
-
-    dispatch_barrier_async(_artistCacheModificationQueue, ^{
         self.cachedArtists = nil;
-    });
-
-    dispatch_barrier_async(_genreCacheModificationQueue, ^{
         self.cachedGenres = nil;
-    });
-
-    dispatch_barrier_async(_groupCacheModificationQueue, ^{
         self.cachedListOfGroups = nil;
-    });
-
-    dispatch_barrier_async(_mediaTitlesCacheModificationQueue, ^{
         self.cachedMediaTitles = nil;
-    });
 
     [self.changeDelegate notifyChange:VLCLibraryModelAllCachesDropped withObject:self];
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6d2e00f0c25065322628592a92993762a4d3c070

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6d2e00f0c25065322628592a92993762a4d3c070
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help