[vlc-devel] Re: Crash in src/input/input_ext-dec.c:154 UnalignedShowBits()

[Rhialto]

On Tue 26 Nov 2002 at 18:07:27 +0100, Gildas Bazin wrote:
> Could you try the attached patch and report the result please ?

I am using the vlc-0.4.6 released version so I am looking at different
versions of the files (input_ext-dec.c version 1.31 and input_dec.c
version 1.36) but I think I got your intention with the following patch:

--- input_ext-dec.c.dist        Thu Nov 14 00:02:30 2002
+++ input_ext-dec.c     Tue Nov 26 20:09:31 2002
@@ -136,7 +136,7 @@
             p_fifo->p_first = p_next;
             p_fifo->i_depth--;
 
-            if( p_fifo->p_first == NULL )
+            while( p_fifo->p_first == NULL )
             {
                 /* No PES in the FIFO. p_last is no longer valid. */
                 p_fifo->pp_last = &p_fifo->p_first;

And it does indeed avoid the crash. I get lots of stuttering in sound
and image. Since I see a call to vlc_cond_wait() I think this indeed
indicates I have a thread synchronisation problem. I'll look into that.

> Gildas
Thanks,
-Olaf.
-- 
___ Olaf 'Rhialto' Seibert      -- The evil eye is caused by the black
\X/ rhialto/at/xs4all.nl        -- tongue - Tom Poes, "Het boze oog", 4456.
-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://www.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>