[vlc-devel] Re: CVS Commit (jpsaman)

[Jean-Paul Saman]

Sigmund Augdal wrote:

>On Sat, Dec 06, 2003 at 11:53:07PM +0100, cvs at videolan.org wrote:
>  
>
>>Update of /var/cvs/videolan/vlc/modules/misc
>>Modified Files:
>>	freetype.c 
>>Log Message:
>>Always use correct datatypes.
>>    
>>
>Are you sure this change still works? The code in question (used to) check
>for the msb in each char to properly decode utf-8. "char" is sometimes
>signed, and then the code will not work. There should be a warning though.
>
I did not consider that, so it might be broken now.

While compiling I saw a lot of signed - unsigned comparisson warnings by 
the compiler and I think it is ugly to have them. Usually the compiller 
is right in flagging these things. So I guess we should be more explicit 
in what type is needed here.

Is the char meant to be unsinged? Why not say so then?
Or does it need to be byte?

-- 


Many greetings,
Jean-Paul Saman

--------------------------------------------------------------
VLC iPAQ maintainer                    http://www.videolan.org
--------------------------------------------------------------
RedHat Certified Engineer         RHCE number: 807202745005548
--------------------------------------------------------------


-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>