[vlc-devel] Toggling fullscreen through a video_filter

[Matthieu Lochegnies]

  Hi,

  i noticed a small problem when using the deinterlace filter, i guess
other filters have the same issue. It seems that the video thread does
not receive the VOUT_FULLSCREEN_CHANGE from the filter.

  I have a dirty workaround in the attached patch (for deinterlace),
it fixes the problem for me but i'm sure there should be locking stuff
around it, or a much better way to do this.

  Yes i know, the clean workaround for the fullscreen is to doubleclick
instead of using a hotkey :)

  Regards

-- 
Prof
-------------- next part --------------
Index: modules/video_filter/deinterlace/deinterlace.c
===================================================================
RCS file: /var/cvs/videolan/vlc/modules/video_filter/deinterlace/deinterlace.c,v
retrieving revision 1.18
diff -u -r1.18 deinterlace.c
--- modules/video_filter/deinterlace/deinterlace.c	22 Dec 2003 14:32:56 -0000	1.18
+++ modules/video_filter/deinterlace/deinterlace.c	30 Dec 2003 19:57:51 -0000
@@ -393,6 +393,12 @@
         p_vout->p_sys->last_date = p_pic->date;
     }
 
+    if (p_vout->i_changes & VOUT_FULLSCREEN_CHANGE)
+    {
+      p_vout->p_sys->p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
+      p_vout->i_changes &= ~VOUT_FULLSCREEN_CHANGE;
+    }
+
     switch( p_vout->p_sys->i_mode )
     {
         case DEINTERLACE_DISCARD: