[vlc-devel] Re: CVS Commit (massiot)

[Gildas Bazin]

On Sunday 11 May 2003 03:00, cvs at videolan.org wrote:
> Update of /cvs/videolan/vlc/src/audio_output
> Modified Files:
> 	output.c 
> 
> Log Message:
> * modules/audio_filter/resampler/coreaudio.c: more accurate frame length
>   calculation
> * modules/audio_output/coreaudio.c: apparently the audio card clock can
>   be screwed, so probe it at every buffer
> * src/audio_output/output.c: Thou shalt not drop buffers
> 
> 

About the last change, are you sure it's the right thing to do ?
The audio output plugins should be buffering a minimum of audio data so if 
p_buffer->start_date < mdate() that means the audio output plugin is very 
late and we should better drop the sample instead of trying to resample. 
The audio output plugin will have started playing blanks anyway so dropping 
should not worsen the audio quality.

--
Gildas
-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>