[vlc-devel] stringreview wxwindows result.

[Derk-Jan Hartman]

OK, first thing is done :)
I fixed a couple of small bugs as well, but there are also several 
things which cannot be dealt with at the moment, or that should be 
dealt with by a wxwindows coder. Here are my results.

ALL: removed some duplicate includes

modules/gui/wxwindows/v4l.cpp
- bitrate and maxbitrate options, while the v4l input doesn't seem to 
handle these.
- no caching or chroma options.
- changed default from stereo to mono

modules/gui/wxwindows/subtitles.cpp:
- this dialog needs serious redesign in both wxwindows and macosx

modules/gui/wxwindows/preferences_widgets.cpp:
- the list of keys for hotkeys is untranslated, don't know how to solve 
this.

modules/gui/wxwindows/playlist.cpp:
- fixed a bug with the loop and repeat var creation
- rightclick should trigger 'select this row' to give visual feedback 
on which playlistitem you will be manipulating
- shuffle == randomize playlist (reorder), random == jumping randomly 
trough playlist without reordering
- repeat and loop and normal behaviour are mutual exclusive, they 
should be combined in one control (macosx too)
- loop can be confusing, because it doesn't clarify 'what' it is 
looping. Loop All/Loop One or Repeat All/Repeat One might be a better 
choice for loop and repeat options (at least at a GUI level) (also goes 
for OSX)

modules/gui/wxwindows/open.cpp:
- I know i'm gonna hit a nerve here, and i think atm it's not even 
advisable, but in a clean userfriendly interface the MRL field should 
not be necessary for an end user.
- "PBC LID" rocky? what is that for label? it's completely useless, who 
knows what PBC LID means?

modules/gui/wxwindows/interface.cpp:
- the 'help' versions of the menu-items create a lot of duplicity and 
don't really add that much clarification. Also for instance the buttons 
don't use this same guidance system, which makes it inconsistent and 
rather useless. The visual space can better be used to represent more 
info about the currently playing file for instance. information which 
often is hardly readable especially when a file is deep in a directory.
- saturation, contrast, brightness etc options should be changed to use 
var_ instead of config_

DJ

---
Universiteit Twente
Derk-Jan Hartman (d.hartman at student.utwente dot nl)
http://home.student.utwente.nl/d.hartman

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>