[vlc-devel] CVS Commit (zorglub)

[cvs at videolan.org]

Update of /var/cvs/videolan/vlc/include
Modified Files:
	vlc_playlist.h 

Update of /var/cvs/videolan/vlc/modules/access/cdda
Modified Files:
	access.c 

Update of /var/cvs/videolan/vlc/modules/access/vcdx
Modified Files:
	access.c 

Update of /var/cvs/videolan/vlc/modules/codec
Modified Files:
	speex.c theora.c vorbis.c 

Update of /var/cvs/videolan/vlc/modules/control
Modified Files:
	http.c 

Update of /var/cvs/videolan/vlc/modules/demux/util
Modified Files:
	id3tag.c 

Update of /var/cvs/videolan/vlc/modules/gui/pda
Modified Files:
	pda_callbacks.c 

Update of /var/cvs/videolan/vlc/modules/gui/wxwindows
Modified Files:
	iteminfo.cpp open.cpp playlist.cpp streamwizard.cpp 

Update of /var/cvs/videolan/vlc/modules/misc
Modified Files:
	sap.c 

Update of /var/cvs/videolan/vlc/src
Modified Files:
	libvlc.c 

Update of /var/cvs/videolan/vlc/src/input
Modified Files:
	input.c 

Update of /var/cvs/videolan/vlc/src/misc
Modified Files:
	win32_specific.c 

Update of /var/cvs/videolan/vlc/src/playlist
Modified Files:
	info.c item-ext.c item.c loadsave.c playlist.c 

Log Message:
Options as infos were bad in several ways: it broke PLAYLIST_GO, used
much memory, and was inconsistent, especially with input_CreateThread
taking an array of options

* Revert to using array of options

* To add an item with options:
    - either use playlist_ItemNew, ItemAddOption, and then AddItem
      (useful if you don't have all your options in an array)
    - either use playlist_AddExt (use this if all your options are
      already in an array)

* To add an item without options: use playlist_Add

You can still add options after an item has been added by using either
playlist_AddOption or playlist_ItemAddOption

* Attempt to improve API and solve thread safety issues.
  - playlist_Item* functions allow to touch items only.
    p_item->lock must be used when needed
    (playlist_ItemNew, playlist_ItemDelete, playlist_Item*Info,
     playlist_ItemSet* )

  - playlist_ItemGetById and ItemGetByPos give you playlist_items
    for GetByPos, you should have the playlist lock

At the moment, the playlist_Set* and playlist_*Info functions are kept (they work with position) but should be avoided.

-- 
zorglub

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>