[vlc-devel] Re: Compile error with latest live libs.

[Arwed von Merkatz]

On Tue, Jul 20, 2004 at 06:16:57PM -0300, James MacLean wrote:
> FYI :),
> 
> Just upgraded live to be able to compile mplayer from CVS. Compiling VLC 
> gave me :
> 
> g++ -DHAVE_CONFIG_H -I. -I. -I../..   -DSYS_LINUX -I../../include 
> `top_builddir="../.." ../../vlc-config --cxxflags builtin livedotcom` 
> -Wsign-compare -Wsign-compare -Wall  -finline-limit-30000 -pipe -c -o 
> liblivedotcom_a-livedotcom.o `test -f 'livedotcom.cpp' || echo 
> './'`livedotcom.cpp
> /usr/lib/live/UsageEnvironment/include/UsageEnvironment.hh: In function 
> `int
>    Open(vlc_object_t*)':
> /usr/lib/live/UsageEnvironment/include/UsageEnvironment.hh:79: error: 
> `virtual
>    UsageEnvironment::~UsageEnvironment()' is protected
> livedotcom.cpp:558: error: within this context
> /usr/lib/live/UsageEnvironment/include/UsageEnvironment.hh: In function 
> `void
>    Close(vlc_object_t*)':
> /usr/lib/live/UsageEnvironment/include/UsageEnvironment.hh:79: error: 
> `virtual
>    UsageEnvironment::~UsageEnvironment()' is protected
> livedotcom.cpp:616: error: within this context
> livedotcom.cpp: In function `void StreamRead(void*, unsigned int, 
> timeval)':
> livedotcom.cpp:911: warning: comparison between signed and unsigned 
> integer
>    expressions
> make[4]: *** [liblivedotcom_a-livedotcom.o] Error 1
 
The live.com api changed, attached is a patch for vlc 0.7.2 that makes
it compile. I'm not sure if it should check the live.com version before
changing the commands, but to get you a working vlc it should be enough.

-- 
Arwed v. Merkatz                              Source Mage GNU/Linux developer
                                                    http://www.sourcemage.org
-------------- next part --------------
--- modules/demux/livedotcom.cpp~	2004-04-27 20:31:35.000000000 +0200
+++ modules/demux/livedotcom.cpp	2004-07-20 12:29:30.761637528 +0200
@@ -132,7 +132,7 @@
         }
         if( ( rtsp = RTSPClient::createNew(*env, 1/*verbose*/, "VLC Media Player" ) ) == NULL )
         {
-            delete env;
+            env->reclaim();
             delete scheduler;
             msg_Err( p_input, "RTSPClient::createNew failed" );
             return VLC_EGENERIC;
@@ -149,7 +149,7 @@
             msg_Err( p_input, "describeURL failed (%s)", env->getResultMsg() );
 
             free( psz_url );
-            delete env;
+            env->reclaim();
             delete scheduler;
             free( p_sys );
             return VLC_EGENERIC;
@@ -160,7 +160,7 @@
 
         //fprintf( stderr, "sdp=%s\n", p_sys->p_sdp );
 
-        delete env;
+        env->reclaim();
         delete scheduler;
 
         var_Create( p_input, "rtsp-tcp", VLC_VAR_BOOL|VLC_VAR_DOINHERIT );
@@ -670,7 +670,7 @@
     }
     if( p_sys->env )
     {
-        delete p_sys->env;
+        p_sys->env->reclaim();
     }
     if( p_sys->scheduler )
     {
@@ -724,7 +724,7 @@
 
     if( p_sys->env )
     {
-        delete p_sys->env;
+        p_sys->env->reclaim();
     }
     if( p_sys->scheduler )
     {