[vlc-devel] Re: vlc: svn commit r7787 (oaubert)
sigmunau at stud.ntnu.no
Thu Jun 3 17:22:01 CEST 2004
I just had a look at this module, and I'm not sure I like everything. First
it seems to depend heavily on the input, which is imho bad, next it uses
lots of old api calls. This isn't that bad, but it will need some update
soon. Third, it doesn't seem thread-safe. The pointers seems to stay put so
it shouldn't crash, but you risk saving half a picture and half an old
picture. Lastly the coding conventions are not followed.
Hope this can be seen as constructive critisism.
On Thu, May 27, 2004 at 05:36:15PM +0200, Subversion daemon wrote:
> r7787 | oaubert | 2004-05-27 17:36:15 +0200 (Thu, 27 May 2004) | 3 lines
> Changed paths:
> M /trunk/configure.ac
> A /trunk/include/snapshot.h
> A /trunk/modules/video_output/snapshot.c
> Snapshot module (dummy video output module keeping a configurable image cache).
> It is chiefly used by the corba module.
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
> If you are in trouble, please contact <postmaster at videolan.org>
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>
More information about the vlc-devel