[vlc-devel] Re: [PATCH] vout_ShowTextAbsolute returns subpicture_t *

[Sigmund Augdal]

Patch does look clear, but I wonder why you want it. Note that the
subpicture as added by these functions by be deleted by the vout thread at
any moment. It should not be stored anywhere except
p_vout->p_last_osd_message which is updated by the deletion function. Even
this solution isn't very good.

Sigmund Augdal


On Mon, Mar 29, 2004 at 12:26:16PM +1000, ozone at algorithm.com.au wrote:
> Hi,
> 
> Here's a very small patch to change the return value of  
> vout_ShowTextAbsolute (in src/video_output/video_text.c) from "void" to  
> "subpicture_t *".  I've also updated the modules which call  
> vout_ShowTextAbsolute to verify the new return value (only one  
> instance: subsdec.c).  Please apply this patch; I'll need it for an  
> upcoming patch I'm about to send in.
> 
> Patch here:
> 
> http://www.algorithm.com.au/files/hacking/vlc/ 
> vout_STA_returns_subpicture_t.diff
> 
> Thanks!
> 
> 
> -- 
> % Andre Pang : trust.in.love.to.save
> 
> -- 
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
> If you are in trouble, please contact <postmaster at videolan.org>

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>