[vlc-devel] Re: vlc: svn commit r12013 (massiot)

[Christophe Massiot]

On Thu, Aug 04, 2005, Rémi Denis-Courmont wrote:
> Le Jeudi 4 Août 2005 22:06, Subversion daemon a écrit :
> > r12013 | massiot | 2005-08-04 21:06:29 +0200 (Thu, 04 Aug 2005) | 2
> > lines Changed paths:
> >    M /trunk/include/network.h
> >
> >  * include/network.h: Fixed vlc_UrlEncode with non-ASCII characters.
> 
> Err, it DID work. It was purposedly NOT using unsigned char so that
> ( c <= 32 ) would catch non-ASCII characters. If that failed on your 
> platform, putting "signed char" explicitly would have done it.

No, it WAS broken, I checked it. I wouldn't bother fixing things if they
don't appear broken when I use VLC. I assume you are aware that c >> 4
doesn't return the same value if c is signed or unsigned ?

-- 
Christophe Massiot.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html