[vlc-devel] Re: [patch] mediacontrol core.c new function

[Filippo Carone]

On Mon, Dec 12, 2005 at 01:09:03PM +0100, Olivier Aubert wrote:
> >  I'm sending this one in order to get a review on this code and to
> > know if I can generally proceed in this way:
> 
> > +void
> > +mediacontrol_playlist_next_item( mediacontrol_Instance *self,
> > +                                 mediacontrol_Exception *exception )
> > +{
> > +    exception=mediacontrol_exception_init( exception );
> > +    if ( !self->p_playlist )
> > +    {
> > +        RAISE( mediacontrol_InternalException, "No playlist" );
> > +        return;
> > +    }
> > +    playlist_Next( self->p_playlist );
> > +}
> Looks fine. Maybe we should remove the _item (from playlist_add_item
> also), it looks redundant anyway. There are other suggestions on the
> wiki.

 Yes, the _item is somewhat redundant. I'm editing the wiki as well,
but I don't know if it would be more productive to discuss here and
use the wiki just to publish the results of our discussions.

fc

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html